datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-3908] Add tests for dogstatsd origin detection on k8s

Open AliDatadog opened this issue 1 year ago • 5 comments
trafficstars

What does this PR do?

This PR adds tests for dogstatsd origin detection using udp on k8s.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

AliDatadog avatar Mar 07 '24 12:03 AliDatadog

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: c6140fa9-3db8-487d-be06-839cff76768a Baseline: 25972295ec1c7c4230a31628d38b3e89bd852a32 Comparison: 633f2be7834ac7fa965e9df95a326987d5748d79

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.59 [-5.97, +7.16]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +1.60 [+1.49, +1.71]
file_to_blackhole % cpu utilization +0.59 [-5.97, +7.16]
tcp_syslog_to_blackhole ingress throughput +0.52 [+0.41, +0.63]
basic_py_check % cpu utilization +0.25 [-2.21, +2.72]
process_agent_standard_check memory utilization +0.24 [+0.21, +0.27]
process_agent_real_time_mode memory utilization +0.18 [+0.14, +0.22]
otel_to_otel_logs ingress throughput +0.17 [-0.26, +0.61]
idle memory utilization +0.09 [+0.05, +0.12]
process_agent_standard_check_with_stats memory utilization +0.07 [+0.05, +0.10]
trace_agent_msgpack ingress throughput +0.02 [+0.00, +0.03]
trace_agent_json ingress throughput +0.01 [-0.02, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.19]
uds_dogstatsd_to_api_cpu % cpu utilization -0.43 [-3.34, +2.49]
pycheck_1000_100byte_tags % cpu utilization -1.12 [-6.31, +4.07]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 07 '24 14:03 pr-commenter[bot]

/trigger-ci --variable RUN_E2E_TESTS=true

AliDatadog avatar Mar 08 '24 15:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #29805712

dd-devflow[bot] avatar Mar 08 '24 15:03 dd-devflow[bot]

/trigger-ci --variable RUN_E2E_TESTS=true

AliDatadog avatar Mar 11 '24 10:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #29879791

dd-devflow[bot] avatar Mar 11 '24 10:03 dd-devflow[bot]

/trigger-ci --variable RUN_E2E_TESTS=true

AliDatadog avatar Mar 13 '24 11:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #30017241

dd-devflow[bot] avatar Mar 13 '24 11:03 dd-devflow[bot]

/merge

AliDatadog avatar Mar 13 '24 13:03 AliDatadog

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 13 '24 13:03 dd-devflow[bot]