refactor windows install tester helper

[clarkb7]

What does this PR do?

extracts tests from the Tester type so they are available for independent use.

• SystemFileIntegrityChecker
• code signing checks now only done in one test, TestInstall

removes install responsibility/capability from Tester, now done via suite.installAgentPackage. removes uninstall responsibility/capability from Tester, now done via suite.uninstallAgentAndRunUninstallTests.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

The SystemFileIntegrityTester has two parts, take an initial snapshot before installing the agent, and then take+compare at a later point, currently done after uninstalling the Agent. Rather than repeat these bits at the top and bottom of every Test method, Tester optionally receives a SystemFileIntegrityTester , and will run validation during TestUninstallExpectations.

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4ea44a06-7848-4be7-91cb-1bb5d70c80fd Baseline: c221f839802de34c89f5b6454a7e2ac675863ea5 Comparison: 26b0c0f9eddd6521f663e45753667d8b4dbac6d5

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.29	[-6.30, +6.88]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	idle	memory utilization	+0.55	[+0.51, +0.60]
➖	process_agent_standard_check	memory utilization	+0.55	[+0.51, +0.59]
➖	process_agent_standard_check_with_stats	memory utilization	+0.37	[+0.33, +0.41]
➖	file_to_blackhole	% cpu utilization	+0.29	[-6.30, +6.88]
➖	file_tree	memory utilization	+0.14	[+0.07, +0.21]
➖	trace_agent_json	ingress throughput	+0.03	[-0.01, +0.07]
➖	otel_to_otel_logs	ingress throughput	+0.01	[-0.63, +0.64]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	process_agent_real_time_mode	memory utilization	-0.00	[-0.05, +0.04]
➖	trace_agent_msgpack	ingress throughput	-0.03	[-0.04, -0.01]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.32	[-0.38, -0.27]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.18	[-2.61, +0.25]
➖	basic_py_check	% cpu utilization	-1.26	[-3.46, +0.94]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[clarkb7]

rebasing for conflicts

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 30421538 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30421538 --os-family=ubuntu

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 5fc2cbb7-62ac-49b9-be0d-a81d1cd8cec2 Baseline: a190b03a94902ecbab2a7f717b1c449cbb182122 Comparison: 5c4d3aadd75d4a45f636756fb400375b610c7239

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-1.88	[-8.16, +4.39]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.15	[-1.55, +3.86]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.78	[+0.69, +0.87]
➖	file_tree	memory utilization	+0.11	[+0.02, +0.20]
➖	idle	memory utilization	+0.06	[+0.02, +0.09]
➖	process_agent_real_time_mode	memory utilization	+0.05	[+0.02, +0.08]
➖	otel_to_otel_logs	ingress throughput	+0.04	[-0.37, +0.45]
➖	trace_agent_json	ingress throughput	+0.01	[-0.02, +0.05]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.02, +0.02]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.03	[-0.05, -0.00]
➖	process_agent_standard_check_with_stats	memory utilization	-0.38	[-0.41, -0.35]
➖	process_agent_standard_check	memory utilization	-0.51	[-0.54, -0.48]
➖	basic_py_check	% cpu utilization	-0.72	[-3.13, +1.69]
➖	file_to_blackhole	% cpu utilization	-1.88	[-8.16, +4.39]
➖	pycheck_1000_100byte_tags	% cpu utilization	-4.61	[-9.38, +0.16]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[clarkb7]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!