datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Improve logs agent status page and logging

Open gh123man opened this issue 1 year ago • 1 comments

What does this PR do?

This PR does several small things:

  • Upgrade backoff retry logs from Debug to Warn
  • Report # of retries and time spent retrying on status page and telemetry
  • Fix a bug where rotated tailers did not report mulit-line handler status (when using agent status -v)
  • Add the currently applied pattern to a tailer using the multiline handler to the verbose status output.

Motivation

improve debugability of the logs agent.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

  • Send some logs and then break the connection to the intake (either via proxy, or using mock intake)
    • run agent status and confirm counters are increasing for retries and retry time
    • check the logs for the warning log messages
  • Configure a regular multi_line pattern and write some logs to a file
    • confirm agent status -v shows the pattern in the tailer info
  • Configure auto_mulit_line_detection and write some logs (such that a pattern matches)
    • confirm agent status -v shows the auto multi-line status
    • rotate the file and write a couple logs
    • confirm agent status -v still shows the auto multi-line status

gh123man avatar Mar 06 '24 17:03 gh123man

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 8ed7bfe6-d5c7-4fbd-9ba5-9de2771090d4 Baseline: 9f092671932f42cbf5b925369b5543ac67921c35 Comparison: 817b656208f403994f444da0c30025b107c419c9

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.24 [-7.77, +5.30]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_real_time_mode memory utilization +0.40 [+0.35, +0.45]
uds_dogstatsd_to_api_cpu % cpu utilization +0.23 [-1.23, +1.68]
trace_agent_json ingress throughput +0.04 [+0.01, +0.07]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.01]
process_agent_standard_check_with_stats memory utilization -0.01 [-0.04, +0.02]
process_agent_standard_check memory utilization -0.35 [-0.38, -0.32]
tcp_syslog_to_blackhole ingress throughput -0.42 [-0.47, -0.36]
otel_to_otel_logs ingress throughput -0.45 [-1.10, +0.21]
idle memory utilization -0.74 [-0.79, -0.69]
file_tree memory utilization -0.91 [-1.02, -0.81]
file_to_blackhole % cpu utilization -1.24 [-7.77, +5.30]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 06 '24 20:03 pr-commenter[bot]

/merge

gh123man avatar Mar 07 '24 14:03 gh123man

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 07 '24 14:03 dd-devflow[bot]