Remove unnecessary helper fn.

[dplepage-dd]

What does this PR do?

Minor code cleanup - remove a helper fn that I wrote before I knew that mapstructure could already do this.

Additional Notes

No QA needed: only a test file changes and the test still passes.

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: caaadb9a-9e49-4d45-9833-064b6914b35a Baseline: e23d246adb5194fd1102baad78fcfccb3d390e15 Comparison: 9bf399aebc3f170581d7c0d5a186fa7973ffd61b

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.30	[-6.29, +6.89]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.60	[+1.15, +4.06]
➖	idle	memory utilization	+1.59	[+1.53, +1.64]
➖	process_agent_standard_check	memory utilization	+0.50	[+0.47, +0.53]
➖	file_to_blackhole	% cpu utilization	+0.30	[-6.29, +6.89]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.26	[+0.21, +0.31]
➖	otel_to_otel_logs	ingress throughput	+0.22	[-0.41, +0.84]
➖	trace_agent_msgpack	ingress throughput	+0.02	[+0.01, +0.03]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.02	[-0.06, +0.03]
➖	file_tree	memory utilization	-0.12	[-0.19, -0.05]
➖	process_agent_standard_check_with_stats	memory utilization	-0.13	[-0.17, -0.09]
➖	process_agent_real_time_mode	memory utilization	-0.14	[-0.17, -0.11]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[dplepage-dd]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!