datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[Backport 7.52.x] AMLII-1528 Fix handling of empty datagrams

Open agent-platform-auto-pr[bot] opened this issue 1 year ago • 1 comments

Backport 013d489a474178d12af1394ac8905b156ae4e3c5 from #23341.

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 6b15407a-6c59-452a-ab4d-527c5da338e2 Baseline: d04acc8e7b2d575076a7b9858a1effbbd66c2cdb Comparison: 2320b11bdd63cbc971d5da3d349628f131fcead7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.78 [-5.76, +7.32]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +1.74 [+1.70, +1.79]
uds_dogstatsd_to_api_cpu % cpu utilization +0.90 [-0.54, +2.33]
file_to_blackhole % cpu utilization +0.78 [-5.76, +7.32]
tcp_syslog_to_blackhole ingress throughput +0.37 [+0.31, +0.42]
file_tree memory utilization +0.08 [-0.01, +0.17]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
process_agent_standard_check_with_stats memory utilization -0.01 [-0.04, +0.03]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
process_agent_real_time_mode memory utilization -0.09 [-0.13, -0.05]
process_agent_standard_check memory utilization -0.49 [-0.54, -0.43]
otel_to_otel_logs ingress throughput -0.93 [-1.56, -0.30]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 06 '24 15:03 pr-commenter[bot]

/merge

vickenty avatar Mar 07 '24 10:03 vickenty

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 07 '24 10:03 dd-devflow[bot]