datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-1093] run kind e2e tests for multiple kube versions and os descriptors

Open adel121 opened this issue 11 months ago • 1 comments

What does this PR do?

Runs the containers E2E tests for the kind scenario for multiple kubernetes versions and multiple OS descriptors.

Motivation

Run the E2E tests on multiple environments (i.e. multiple versions of k8s and os descriptors)

Additional Notes

Possible Drawbacks / Trade-offs

  • Increases cost of running e2e, because we are spawning one gitlab runner per version / os descriptor. However, doing all the tests for all versions in one gitlab runner is challenging and not straightforward. The challenge is in handling parallelism and test log management. If we run all versions in one gitlab runner only sequentially, it will take a very long time to finish the tests. If we run them in parallel within the same gitlab runner, the logs would not be comprehensible.

Describe how to test/QA your changes

adel121 avatar Mar 06 '24 13:03 adel121

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 0803d2eb-04a4-4b20-a0a0-283521d98168 Baseline: b4f0a172d309dc5b7689bc9674e0487e4fd0cf1b Comparison: b71db97b6581e79cb8b80ee1006a84e8618ce050

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.41 [-5.93, +6.75]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.91 [-1.95, +3.77]
process_agent_standard_check_with_stats memory utilization +0.59 [+0.56, +0.62]
process_agent_standard_check memory utilization +0.59 [+0.55, +0.62]
file_to_blackhole % cpu utilization +0.41 [-5.93, +6.75]
process_agent_real_time_mode memory utilization +0.38 [+0.34, +0.41]
file_tree memory utilization +0.36 [+0.27, +0.45]
idle memory utilization +0.33 [+0.30, +0.37]
tcp_syslog_to_blackhole ingress throughput +0.06 [-0.02, +0.13]
trace_agent_json ingress throughput +0.02 [-0.00, +0.04]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.06, +0.06]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.08, +0.03]
otel_to_otel_logs ingress throughput -0.35 [-1.01, +0.30]
basic_py_check % cpu utilization -2.27 [-4.75, +0.21]
pycheck_1000_100byte_tags % cpu utilization -2.52 [-7.41, +2.38]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 06 '24 16:03 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=35558454 --os-family=ubuntu

pr-commenter[bot] avatar Mar 18 '24 15:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 93ff5b4f-642f-41ae-87dc-c3e86e028e97 Baseline: e49ead2a99df046f8b13a42beeb05afd0f1633dc Comparison: ae6640448fc8d92186885d358f9764a590b73233

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +3.43 [-1.46, +8.32]
file_tree memory utilization +2.01 [+1.91, +2.12]
uds_dogstatsd_to_api_cpu % cpu utilization +0.35 [-2.58, +3.29]
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.03, +0.07]
idle memory utilization +0.01 [-0.03, +0.05]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
otel_to_otel_logs ingress throughput -0.02 [-0.41, +0.37]
uds_dogstatsd_to_api ingress throughput -0.03 [-0.23, +0.18]
basic_py_check % cpu utilization -0.91 [-3.86, +2.03]
tcp_syslog_to_blackhole ingress throughput -3.02 [-23.29, +17.26]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 18 '24 16:03 pr-commenter[bot]

/merge

adel121 avatar Mar 25 '24 10:03 adel121

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 25 '24 10:03 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 25 '24 14:03 dd-devflow[bot]

[Fast Unit Tests Report]

On pipeline 35558454 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

/merge

adel121 avatar Apr 19 '24 13:04 adel121

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 19 '24 13:04 dd-devflow[bot]

/merge --cancel

adel121 avatar Apr 19 '24 14:04 adel121

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar Apr 19 '24 14:04 dd-devflow[bot]

/merge

adel121 avatar Apr 23 '24 08:04 adel121

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 24m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 23 '24 08:04 dd-devflow[bot]

/merge --cancel

adel121 avatar Apr 23 '24 08:04 adel121

:warning: MergeQueue

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar Apr 23 '24 08:04 dd-devflow[bot]

/merge

adel121 avatar May 31 '24 14:05 adel121

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 4 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar May 31 '24 14:05 dd-devflow[bot]