datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Fix connection leak when using the api/util from the metadata comp

Open hush-hush opened this issue 1 year ago • 4 comments

What does this PR do?

Fix connection leak when using the api/util from the metadata comp

Describe how to test/QA your changes

Security-agent team to test if connection leak is gone.

hush-hush avatar Mar 06 '24 09:03 hush-hush

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 346daa15-f30d-49d5-85f3-a9c96f326279 Baseline: 6964da53aae4a788c540294470fa574c6539710c Comparison: 44bab8c4b63c55cbe6b9e394d3257e65de23225d

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.72 [-5.83, +7.28]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.43 [+0.81, +2.05]
file_to_blackhole % cpu utilization +0.72 [-5.83, +7.28]
process_agent_standard_check_with_stats memory utilization +0.58 [+0.55, +0.62]
process_agent_standard_check memory utilization +0.36 [+0.32, +0.40]
process_agent_real_time_mode memory utilization +0.01 [-0.02, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.00 [-0.02, +0.01]
trace_agent_json ingress throughput -0.03 [-0.06, -0.01]
idle memory utilization -0.06 [-0.10, -0.02]
uds_dogstatsd_to_api_cpu % cpu utilization -0.19 [-1.62, +1.24]
file_tree memory utilization -0.59 [-0.70, -0.48]
tcp_syslog_to_blackhole ingress throughput -0.88 [-0.94, -0.82]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 06 '24 11:03 pr-commenter[bot]

/merge

Kaderinho avatar Mar 06 '24 13:03 Kaderinho

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 06 '24 13:03 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 06 '24 17:03 dd-devflow[bot]

/merge

Kaderinho avatar Mar 07 '24 10:03 Kaderinho

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 07 '24 10:03 dd-devflow[bot]

/merge

Kaderinho avatar Mar 07 '24 11:03 Kaderinho

:x: MergeQueue

PR is already in db with waiting status

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 07 '24 11:03 dd-devflow[bot]

/merge -c

Kaderinho avatar Mar 07 '24 11:03 Kaderinho

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 07 '24 11:03 dd-devflow[bot]

/merge

Kaderinho avatar Mar 07 '24 11:03 Kaderinho

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 07 '24 11:03 dd-devflow[bot]

/merge

Kaderinho avatar Mar 07 '24 11:03 Kaderinho

:x: MergeQueue

PR already in the queue with status in_progress

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 07 '24 11:03 dd-devflow[bot]