event monitor: improve OS gating of network common code

[paulcacheux]

trafficstars

What does this PR do?

The event monitor is currently supported only on linux. Some network code implements the required interface to "support" windows, but the code is not specific to windows and could actually be used to support all non-linux (including darwin) operating systems. This PR basically changes windows to !linux in order to support this.

Extracted from https://github.com/DataDog/datadog-agent/pull/21156

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: eb0b6897-ff86-4e52-b44e-bc0e1f7c1c56 Baseline: 50e09c4179052808af669b00f80005d02ce51ef7 Comparison: 5b8219840089fe88086a03d396701b4ca14c802f

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+3.55	[-3.16, +10.26]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+3.55	[-3.16, +10.26]
➖	file_tree	memory utilization	+0.32	[+0.25, +0.38]
➖	process_agent_standard_check	memory utilization	+0.25	[+0.22, +0.28]
➖	trace_agent_msgpack	ingress throughput	+0.01	[-0.00, +0.02]
➖	idle	memory utilization	+0.00	[-0.04, +0.04]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	process_agent_real_time_mode	memory utilization	-0.01	[-0.04, +0.03]
➖	trace_agent_json	ingress throughput	-0.03	[-0.07, +0.01]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.24	[-0.29, -0.19]
➖	process_agent_standard_check_with_stats	memory utilization	-0.46	[-0.49, -0.44]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.03	[-2.46, +0.40]
➖	otel_to_otel_logs	ingress throughput	-1.08	[-1.73, -0.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[paulcacheux]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!