datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

WIP - sort composite tags immediately before serializing them

Open KrisKennawayDD opened this issue 1 year ago • 2 comments
trafficstars

There's probably a more CPU-efficient way to do this but it will let us estimate the potential compression impact.

KrisKennawayDD avatar Mar 05 '24 18:03 KrisKennawayDD

Current dependencies on/for this PR:

  • main:
    • PR #23454 👈

This comment was autogenerated by Freephite.

KrisKennawayDD avatar Mar 05 '24 18:03 KrisKennawayDD

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: b9d76d62-652d-4c9f-bc69-42811ac24582 Baseline: 6964da53aae4a788c540294470fa574c6539710c Comparison: 5f9b3a82d21b961f0931be641b8ac8cdab66c2fe

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.29 [-6.24, +6.82]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +0.74 [+0.69, +0.80]
process_agent_standard_check_with_stats memory utilization +0.61 [+0.58, +0.64]
otel_to_otel_logs ingress throughput +0.49 [-0.14, +1.13]
process_agent_real_time_mode memory utilization +0.44 [+0.41, +0.48]
file_to_blackhole % cpu utilization +0.29 [-6.24, +6.82]
file_tree memory utilization +0.11 [+0.05, +0.17]
process_agent_standard_check memory utilization +0.06 [+0.03, +0.10]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
idle memory utilization -0.29 [-0.33, -0.26]
uds_dogstatsd_to_api_cpu % cpu utilization -1.25 [-2.68, +0.18]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 05 '24 19:03 pr-commenter[bot]