datadog-agent
datadog-agent copied to clipboard
[macOS] Fix gui app that wasn't unloaded once loaded
What does this PR do?
Move code that looks for alive user-level datadog-agent process before it gets unloaded.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 8e0236be-de24-457d-a7fe-850494361779 Baseline: 0c480fb5c97b95b152032418b49781b3bc58f0ac Comparison: 73e03158246f431ca0980e21abe76d89587175ca
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +0.62 | [-5.98, +7.22] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.51 | [+0.05, +2.96] |
➖ | file_to_blackhole | % cpu utilization | +0.62 | [-5.98, +7.22] |
➖ | idle | memory utilization | +0.23 | [+0.19, +0.28] |
➖ | process_agent_standard_check | memory utilization | +0.10 | [+0.06, +0.15] |
➖ | trace_agent_json | ingress throughput | +0.02 | [-0.03, +0.06] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | trace_agent_msgpack | ingress throughput | -0.03 | [-0.04, -0.02] |
➖ | process_agent_real_time_mode | memory utilization | -0.08 | [-0.12, -0.03] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.36 | [-0.40, -0.31] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.57 | [-0.62, -0.52] |
➖ | file_tree | memory utilization | -0.77 | [-0.88, -0.66] |
➖ | otel_to_otel_logs | ingress throughput | -1.63 | [-2.27, -0.98] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".