fix domain test logfile

[clarkb7]

trafficstars

What does this PR do?

Fix path of installer log file in domain tests

Motivation

https://github.com/DataDog/datadog-agent/pull/23174 moved the InstallMSI call from base to the agent package so the default application of the OutputDir prefix was lost.

Additional Notes

Possible Drawbacks / Trade-offs

We could still have base add the OutputDir prefix if the logfile option is just a filename, but then passing WithInstallLogFile to suite.InstallAgent would have different behavior than windowsAgent.InstallAgent and that seems confusing.

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: d59a762e-134f-4f73-a118-37d9967179af Baseline: 3edc357af04d6ca389bdaac6de140e83ddce135f Comparison: 5e45c512bb58952490c1089c23b96e1de7852436

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.53	[-7.08, +6.03]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	otel_to_otel_logs	ingress throughput	+0.89	[+0.25, +1.53]
➖	process_agent_standard_check	memory utilization	+0.45	[+0.42, +0.48]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.30	[-1.16, +1.75]
➖	process_agent_standard_check_with_stats	memory utilization	+0.26	[+0.23, +0.29]
➖	file_tree	memory utilization	+0.04	[-0.03, +0.10]
➖	process_agent_real_time_mode	memory utilization	+0.03	[-0.00, +0.06]
➖	trace_agent_msgpack	ingress throughput	+0.01	[-0.00, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.01	[-0.03, +0.01]
➖	idle	memory utilization	-0.04	[-0.07, +0.00]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.16	[-0.20, -0.11]
➖	file_to_blackhole	% cpu utilization	-0.53	[-7.08, +6.03]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[clarkb7]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[chouetz]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:x: MergeQueue

Tests failed on this commit cb7861a

You should fix those tests and then re-add your pull request to the queue!

Details

some checks are failing:

• comment

If you need support, contact us on Slack #ci-interfaces with those details!

[clarkb7]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

[clarkb7]

/merge -c

[dd-devflow[bot]]

:warning: MergeQueue

This merge request build was cancelled

If you need support, contact us on Slack #ci-interfaces!

[clarkb7]

rebase for fix for serverless size

[clarkb7]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!