datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1227] Add init to loger to avoid bufferrisation

Open louis-cqrl opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

  • Add an log_init.go file in order to initialise the logger before starting test

Motivation

  • Reduce buffer size which contribute to test flakiness

Additional Notes

  • Set all logger's locker at the same level
  • Change 'pkg/process/checks/host_info_test.go' to go along with 'log_init.go' changes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

TBD

louis-cqrl avatar Mar 04 '24 17:03 louis-cqrl

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Mar 04 '24 17:03 bits-bot

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 42b8a9a7-dc4d-4352-99fc-26a4a7da3ffc Baseline: 2664773d938aa5884583c7afe3f26b63b401b6a9 Comparison: 6193363cb301f4a7b0ce2b4298e1eda8316a6fc2

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.31 [-6.87, +6.24]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.59 [+0.12, +3.06]
otel_to_otel_logs ingress throughput +1.22 [+0.56, +1.87]
idle memory utilization +0.71 [+0.68, +0.75]
basic_py_check % cpu utilization +0.67 [-1.57, +2.92]
tcp_syslog_to_blackhole ingress throughput +0.01 [-0.05, +0.06]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.05, +0.02]
process_agent_real_time_mode memory utilization -0.02 [-0.06, +0.01]
file_tree memory utilization -0.07 [-0.13, +0.00]
process_agent_standard_check_with_stats memory utilization -0.21 [-0.23, -0.18]
file_to_blackhole % cpu utilization -0.31 [-6.87, +6.24]
process_agent_standard_check memory utilization -0.63 [-0.66, -0.61]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 04 '24 18:03 pr-commenter[bot]

/merge

louis-cqrl avatar Mar 08 '24 12:03 louis-cqrl

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 08 '24 12:03 dd-devflow[bot]

/merge

louis-cqrl avatar Mar 08 '24 15:03 louis-cqrl

:x: MergeQueue

PR is already in db with waiting status

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 08 '24 15:03 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 08 '24 16:03 dd-devflow[bot]

/merge

louis-cqrl avatar Mar 08 '24 16:03 louis-cqrl

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 08 '24 16:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 08 '24 17:03 dd-devflow[bot]