datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1226] Add flare information from the status component

Open GustavoCaso opened this issue 1 year ago • 2 comments

What does this PR do?

Remove the hardcoded dependency between the flare component and the status pkg. Since the status component is used in the main agent we can use the Fx value group functionality.

The status component now register a flare provider 🎉

While working on this PR we faced and issue with Fx and a dependency cycle between components. To circumvent this we decided to extract the RC client status provider to a separate component. I provided a detail comment explaining the issue.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Ensure the flare command works as expected. Validate that the file status.log in part of the flare archive and that includes the status output.

GustavoCaso avatar Mar 04 '24 17:03 GustavoCaso

Go Package Import Differences

Baseline: 92fd220b5f7cc1bd4ed0a58479ccc8809bf2b3a1 Comparison: 076dd23e149d72a2dfcacd80b585939590cf010c

binaryosarchchange
agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
agentlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
agentwindowsamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
agentwindows386
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
agentdarwinamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
agentdarwinarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
iot-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
iot-agentlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
heroku-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
process-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
process-agentlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
process-agentwindowsamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
process-agentdarwinamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
process-agentdarwinarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl
heroku-process-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/remote-config
+github.com/DataDog/datadog-agent/comp/remote-config/rcstatus/rcstatusimpl

cit-pr-commenter[bot] avatar Mar 05 '24 14:03 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 08ca2bbe-7846-41b8-a498-95941e682af5 Baseline: 92fd220b5f7cc1bd4ed0a58479ccc8809bf2b3a1 Comparison: 076dd23e149d72a2dfcacd80b585939590cf010c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.10 [-6.64, +6.44]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +0.45 [-0.18, +1.09]
process_agent_real_time_mode memory utilization +0.44 [+0.41, +0.47]
idle memory utilization +0.32 [+0.28, +0.35]
trace_agent_json ingress throughput +0.03 [-0.01, +0.07]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.02 [-0.04, -0.01]
process_agent_standard_check_with_stats memory utilization -0.05 [-0.08, -0.02]
file_tree memory utilization -0.07 [-0.13, -0.01]
file_to_blackhole % cpu utilization -0.10 [-6.64, +6.44]
tcp_syslog_to_blackhole ingress throughput -0.21 [-0.26, -0.16]
process_agent_standard_check memory utilization -0.45 [-0.48, -0.41]
uds_dogstatsd_to_api_cpu % cpu utilization -0.60 [-2.04, +0.85]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 05 '24 16:03 pr-commenter[bot]

/merge

GustavoCaso avatar Mar 06 '24 10:03 GustavoCaso

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 06 '24 10:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 06 '24 10:03 dd-devflow[bot]