datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1259] Remove some calls to GetGlobalStore

Open ogaca-dd opened this issue 1 year ago • 1 comments

What does this PR do?

This PR removes some calls to GetGlobalStore in order to easily remove workloadmeta globalStore in a later PR.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Agent shared component

  • Check that agent diagnose and agent flare behave the same as before.

Other teams

Check workload metadata works as before for the following locations:

ogaca-dd avatar Mar 04 '24 15:03 ogaca-dd

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 1bab7247-8dc8-4eeb-9ff3-ae84f31bc4c8 Baseline: 6b1be21b1b8f9767738716909cff2948b1219b08 Comparison: 09527f5b4640cfe41237ad0877743b5000c2a5ba

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.16 [-6.41, +6.73]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.81 [+0.74, +0.87]
otel_to_otel_logs ingress throughput +0.23 [-0.41, +0.86]
file_to_blackhole % cpu utilization +0.16 [-6.41, +6.73]
process_agent_real_time_mode memory utilization +0.12 [+0.08, +0.16]
process_agent_standard_check_with_stats memory utilization +0.04 [+0.01, +0.07]
trace_agent_json ingress throughput +0.03 [-0.00, +0.07]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, -0.00]
process_agent_standard_check memory utilization -0.08 [-0.12, -0.05]
tcp_syslog_to_blackhole ingress throughput -0.12 [-0.18, -0.07]
idle memory utilization -0.21 [-0.24, -0.18]
uds_dogstatsd_to_api_cpu % cpu utilization -2.29 [-3.69, -0.89]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 06 '24 12:03 pr-commenter[bot]

/merge

ogaca-dd avatar Mar 12 '24 15:03 ogaca-dd

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 15:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 12 '24 16:03 dd-devflow[bot]