datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS] fix rare event corruption

Open paulcacheux opened this issue 1 year ago • 2 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Mar 03 '24 11:03 paulcacheux

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 3964c737-27ca-4d7f-8347-3f0a4dcdf5e9 Baseline: c8b0d374fa17550453b7e42c2bc3ea2573a71559 Comparison: 77c0972c614dfcef2f6ea5ae011aaee4988bc189

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.54 [-7.10, +6.03]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +1.50 [-3.75, +6.75]
otel_to_otel_logs ingress throughput +0.66 [+0.04, +1.27]
uds_dogstatsd_to_api_cpu % cpu utilization +0.40 [-2.73, +3.53]
file_tree memory utilization +0.16 [+0.10, +0.23]
process_agent_standard_check_with_stats memory utilization +0.11 [+0.08, +0.14]
process_agent_real_time_mode memory utilization +0.04 [-0.00, +0.07]
trace_agent_msgpack ingress throughput +0.03 [+0.01, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.05, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.06, +0.06]
trace_agent_json ingress throughput -0.00 [-0.04, +0.03]
process_agent_standard_check memory utilization -0.03 [-0.06, -0.00]
idle memory utilization -0.29 [-0.33, -0.26]
tcp_syslog_to_blackhole ingress throughput -0.31 [-0.40, -0.23]
basic_py_check % cpu utilization -0.32 [-2.58, +1.94]
file_to_blackhole % cpu utilization -0.54 [-7.10, +6.03]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 03 '24 12:03 pr-commenter[bot]

Go Package Import Differences

Baseline: c8b0d374fa17550453b7e42c2bc3ea2573a71559 Comparison: 77c0972c614dfcef2f6ea5ae011aaee4988bc189

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
agentlinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
iot-agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
iot-agentlinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
heroku-agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
cluster-agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
cluster-agentlinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
process-agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
process-agentlinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
heroku-process-agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
security-agentlinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
security-agentlinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
system-probelinuxamd64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms
system-probelinuxarm64
+1, -0
+github.com/cilium/ebpf/internal/kallsyms

cit-pr-commenter[bot] avatar Mar 08 '24 16:03 cit-pr-commenter[bot]

/merge

paulcacheux avatar Mar 11 '24 22:03 paulcacheux

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 11 '24 22:03 dd-devflow[bot]

:x: MergeQueue

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 11 '24 22:03 dd-devflow[bot]

/merge -c

paulcacheux avatar Mar 11 '24 22:03 paulcacheux

/merge

paulcacheux avatar Mar 11 '24 22:03 paulcacheux

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 11 '24 22:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 11 '24 23:03 dd-devflow[bot]