datadog-agent
datadog-agent copied to clipboard
disable prebuilt ebpf conntracker + test on kernels < 4.14
we have seen a lot of failures in CI for TestOffsetGuess
in kernel 4.4. A decision has been made to disable this test for kernels < 4.14 (the next highest version we run in CI which is passing) as well as the prebuilt ebpf conntracker itself as it's likely that offsets are being guessed incorrect on these kernels. In this case we will always fall back to the netlink conntracker which will at least be consistently functional.
What does this PR do?
Motivation
https://datadoghq.atlassian.net/browse/NPM-3149
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 5b9dc64e-8d8e-4cff-af58-802ea1597744 Baseline: c7b1b2024b8fa779dcb8d21d5d227210a8af95cb Comparison: 9927899ef8932fb91f4abda9f41e69bd3bfb994e
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +0.24 | [-6.32, +6.81] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.02 | [+0.59, +3.46] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.59 | [+0.54, +0.65] |
➖ | process_agent_real_time_mode | memory utilization | +0.25 | [+0.22, +0.29] |
➖ | file_to_blackhole | % cpu utilization | +0.24 | [-6.32, +6.81] |
➖ | process_agent_standard_check | memory utilization | +0.06 | [+0.02, +0.09] |
➖ | trace_agent_json | ingress throughput | +0.04 | [+0.01, +0.06] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.01 | [-0.03, +0.02] |
➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.03, +0.00] |
➖ | otel_to_otel_logs | ingress throughput | -0.29 | [-0.92, +0.34] |
➖ | idle | memory utilization | -0.30 | [-0.34, -0.27] |
➖ | file_tree | memory utilization | -0.31 | [-0.37, -0.25] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Do we need to make any special allowances for the redhat kernels that show up as kernel version 3.x ?
@leeavital good point... we have a check for this in other places I will add here
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is next! (estimated merge in less than 28m)
Use /merge -c
to cancel this operation!