feat(preinst): fix service not correctly unloaded

[Pythyu]

What does this PR do?

Ensure to correctly unload macOS launchctl services the -w parameter was missing.

Motivation

Installing the agent back to back on macOS followed by a restart re-activated supposedly unloaded services and launched multiple tray icon app

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: fd4b292a-8e9e-41ef-9fad-d97f64fb7cff Baseline: 2fb610fe5c7584bf5e21c16a7241de761bf7fee3 Comparison: 20fb3c3bd05b753cb32e37d6615b5e1306ec3c58

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.68	[-7.21, +5.84]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.63	[+0.18, +3.07]
➖	process_agent_standard_check	memory utilization	+0.32	[+0.27, +0.37]
➖	otel_to_otel_logs	ingress throughput	+0.22	[-0.43, +0.88]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.00	[-0.03, +0.03]
➖	trace_agent_msgpack	ingress throughput	-0.01	[-0.02, +0.01]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.11	[-0.17, -0.05]
➖	process_agent_standard_check_with_stats	memory utilization	-0.14	[-0.19, -0.09]
➖	process_agent_real_time_mode	memory utilization	-0.25	[-0.30, -0.20]
➖	idle	memory utilization	-0.56	[-0.60, -0.52]
➖	file_to_blackhole	% cpu utilization	-0.68	[-7.21, +5.84]
➖	file_tree	memory utilization	-0.84	[-0.96, -0.71]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".