Only provide dummy responses to List all external metrics

[vboulineau]

trafficstars

What does this PR do?

As upstream recommends, only return dummy responses to list all external metrics as the List is not used by autoscaler controllers and wastes resources on all Discovery calls.

Motivation

Optim

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Non-regression only required. Will be tested extensively internally, no need for manual QA.

[cit-pr-commenter[bot]]

Go Package Import Differences

Baseline: 21a47b28b023016a051f40287b857b3fa99f308f Comparison: bf7299a66cb91bb15fc270756de176de58023f56

binary	os	arch	change
agent	linux	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
agent	linux	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
agent	windows	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
agent	darwin	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
agent	darwin	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
cluster-agent	linux	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
cluster-agent	linux	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
process-agent	linux	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
process-agent	linux	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
process-agent	windows	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
process-agent	darwin	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
process-agent	darwin	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
security-agent	linux	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
security-agent	linux	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
system-probe	linux	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
system-probe	linux	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
system-probe	windows	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
trace-agent	linux	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
trace-agent	linux	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
trace-agent	windows	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
trace-agent	darwin	amd64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
trace-agent	darwin	arm64	+1, -0 +sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: b50ea2d1-be1a-4dc8-b6fd-eb8292ee7c93 Baseline: 21a47b28b023016a051f40287b857b3fa99f308f Comparison: bf7299a66cb91bb15fc270756de176de58023f56

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.64	[-7.18, +5.89]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_tree	memory utilization	+0.38	[+0.32, +0.45]
➖	process_agent_real_time_mode	memory utilization	+0.31	[+0.27, +0.34]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.00	[-0.03, +0.03]
➖	idle	memory utilization	-0.03	[-0.06, +0.01]
➖	process_agent_standard_check	memory utilization	-0.24	[-0.28, -0.20]
➖	process_agent_standard_check_with_stats	memory utilization	-0.29	[-0.32, -0.26]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.36	[-0.42, -0.30]
➖	file_to_blackhole	% cpu utilization	-0.64	[-7.18, +5.89]
➖	otel_to_otel_logs	ingress throughput	-0.71	[-1.33, -0.10]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.32	[-2.72, +0.09]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[vboulineau]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 29m)

Use /merge -c to cancel this operation!