datadog-agent
datadog-agent copied to clipboard
[CWS] Set working directory to config dir in functional tests
What does this PR do?
Set a valid working directory to run the testsuite.
Motivation
Test could fail with
TestProcessInterpreter/interpreted_exec-docker
[2024-02-29
process_test.go:2112: could not run /tmp/interpretedExec.sh: exit status 127
process_test.go:2114: shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
Executing echo insIDe a bash script
/tmp/interpretedExec.sh: line 5: pyscript.py: No such file or directory
Back to bash
chmod: cannot access ‘pyscript.py’: No such file or directory
/tmp/interpretedExec.sh: line 15: ./pyscript.py: No such file or directory
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: b4c875f6-7005-466d-8a6c-fef8283275dd Baseline: d2baec44ac3d78b115c52cafb8ad1e87e80d3475 Comparison: c30d2826de6f4c330d282f2bdbef4026888c34f9
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.83 | [-7.32, +5.67] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.01 | [+0.54, +3.48] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.92 | [+0.87, +0.98] |
| ➖ | process_agent_standard_check | memory utilization | +0.29 | [+0.24, +0.34] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.08 | [+0.03, +0.12] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.01 | [-0.04, +0.06] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.02 | [-0.05, +0.02] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.03, -0.01] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.12 | [-0.76, +0.52] |
| ➖ | idle | memory utilization | -0.18 | [-0.22, -0.14] |
| ➖ | file_to_blackhole | % cpu utilization | -0.83 | [-7.32, +5.67] |
| ➖ | file_tree | memory utilization | -1.08 | [-1.18, -0.97] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is next! (estimated merge in less than 33m)
Use /merge -c to cancel this operation!