datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[WKINT-386][Windows][CWS] Additional tests for FRIM

Open derekwbrown opened this issue 1 year ago • 1 comments

This PR adds an additional test for FRIM/registry testing. It's primary purpose is to illuminate a potential usability issue.

This PR has no agent code. It is entirely a test.

derekwbrown avatar Feb 28 '24 22:02 derekwbrown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: b9de7e7f-a197-4b46-a9a8-05f12e9eae79 Baseline: 1502319de6e007efa56e554410a4d753fc76e198 Comparison: 2e2c43bb08f6d40e0024403f02faf758916f7f44

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.53 [-7.04, +5.98]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.65 [+0.20, +3.10]
tcp_syslog_to_blackhole ingress throughput +0.62 [+0.56, +0.68]
process_agent_real_time_mode memory utilization +0.48 [+0.44, +0.53]
process_agent_standard_check memory utilization +0.37 [+0.33, +0.41]
process_agent_standard_check_with_stats memory utilization +0.11 [+0.07, +0.15]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.03 [-0.06, -0.01]
idle memory utilization -0.51 [-0.56, -0.47]
file_to_blackhole % cpu utilization -0.53 [-7.04, +5.98]
otel_to_otel_logs ingress throughput -0.94 [-1.56, -0.31]
file_tree memory utilization -0.96 [-1.04, -0.88]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 28 '24 23:02 pr-commenter[bot]

[Fast Unit Tests Report]

On pipeline 32158964 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=32158964 --os-family=ubuntu

pr-commenter[bot] avatar Apr 15 '24 23:04 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: c47c6ea0-125b-4111-a0d8-220bb74acf83 Baseline: 9c6a4e6e86276855fd6eab66cbee2711e9e75f04 Comparison: abcaadb111cc5999340bd2cf4fe22630c39f8875

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.64 [-6.78, +5.50]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +2.13 [-0.42, +4.68]
uds_dogstatsd_to_api_cpu % cpu utilization +1.05 [-1.89, +3.98]
tcp_syslog_to_blackhole ingress throughput +0.61 [+0.53, +0.69]
file_tree memory utilization +0.57 [+0.46, +0.68]
idle memory utilization +0.14 [+0.10, +0.19]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.03]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.04]
trace_agent_json ingress throughput -0.01 [-0.03, +0.00]
otel_to_otel_logs ingress throughput -0.02 [-0.45, +0.41]
process_agent_standard_check memory utilization -0.14 [-0.20, -0.09]
process_agent_real_time_mode memory utilization -0.23 [-0.28, -0.18]
process_agent_standard_check_with_stats memory utilization -0.23 [-0.28, -0.19]
file_to_blackhole % cpu utilization -0.64 [-6.78, +5.50]
pycheck_1000_100byte_tags % cpu utilization -2.31 [-7.15, +2.53]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Apr 16 '24 00:04 pr-commenter[bot]

/merge

derekwbrown avatar Apr 16 '24 06:04 derekwbrown

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 16 '24 06:04 dd-devflow[bot]