datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS] keep track of the original policy

Open safchain opened this issue 11 months ago • 1 comments

What does this PR do?

Report the default policy instead of the custom one when using override.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

safchain avatar Feb 28 '24 17:02 safchain

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 7ca8c1fc-0f66-458b-93a4-ef9cb964013d Baseline: c08e2d1a3ca323b1234ba1d29e6deca79c9eac4e Comparison: 10b1ce7abd1792f8a62dec92c2d321e108c6e6ad Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.22 [-6.36, +6.79]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +1.87 [+1.75, +1.98]
tcp_syslog_to_blackhole ingress throughput +0.52 [+0.47, +0.57]
file_to_blackhole % cpu utilization +0.22 [-6.36, +6.79]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.02 [-0.06, +0.02]
trace_agent_msgpack ingress throughput -0.02 [-0.02, -0.01]
trace_agent_json ingress throughput -0.06 [-0.09, -0.02]
uds_dogstatsd_to_api_cpu % cpu utilization -0.06 [-1.48, +1.36]
otel_to_otel_logs ingress throughput -0.09 [-0.74, +0.55]
process_agent_standard_check_with_stats memory utilization -0.14 [-0.18, -0.10]
process_agent_standard_check memory utilization -0.42 [-0.46, -0.37]
idle memory utilization -0.69 [-0.74, -0.65]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 28 '24 19:02 pr-commenter[bot]

/merge

safchain avatar Mar 04 '24 14:03 safchain

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 44m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 04 '24 14:03 dd-devflow[bot]