datadog-agent
datadog-agent copied to clipboard
Add GaugeWithTimestamp and CountWithTimestamp methods to sender api
What does this PR do?
This PR adds GaugeWithTimestamp and CountWithTimestamp methods to the sender api, similarly to dogstatsd
NDMII-2543
Motivation
This will be needed to ingest late metrics from a new NDM Integration
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: d594ccbe-d430-467b-9592-72fade4c3d7a Baseline: b4f0a172d309dc5b7689bc9674e0487e4fd0cf1b Comparison: 9cc9ea9f9029c27886d3378349c842096f0a4852
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.85 | [-7.17, +5.47] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +1.11 | [+0.44, +1.77] |
| ➖ | basic_py_check | % cpu utilization | +0.63 | [-1.78, +3.04] |
| ➖ | process_agent_standard_check | memory utilization | +0.14 | [+0.10, +0.19] |
| ➖ | idle | memory utilization | +0.14 | [+0.11, +0.17] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.08 | [+0.05, +0.12] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.02 | [-0.03, +0.08] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | file_tree | memory utilization | -0.36 | [-0.47, -0.25] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.57 | [-0.60, -0.54] |
| ➖ | file_to_blackhole | % cpu utilization | -0.85 | [-7.17, +5.47] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.91 | [-2.47, +0.65] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue
Added to the queue.
This build is next! (estimated merge in less than 27m)
Use /merge -c to cancel this operation!