Download VM images using curl

[usamasaqib]

What does this PR do?

This PR pulls in changes from test-infra-definitions to use curl to download VM images instead of aria2c.

Motivation

Described in https://github.com/DataDog/test-infra-definitions/pull/637

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 6311e3ea-ba46-4970-b47c-5535baca7215 Baseline: 8aad81c2df11bab6faeb2532d038f7717bdbff71 Comparison: 48db57debcc8e83fc6c9c6f3b27dda7e3ed91f43 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.26	[-6.82, +6.31]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	tcp_syslog_to_blackhole	ingress throughput	+1.04	[+0.98, +1.10]
➖	otel_to_otel_logs	ingress throughput	+0.98	[+0.36, +1.59]
➖	process_agent_standard_check	memory utilization	+0.97	[+0.92, +1.02]
➖	process_agent_standard_check_with_stats	memory utilization	+0.16	[+0.12, +0.20]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.02, +0.02]
➖	trace_agent_json	ingress throughput	-0.03	[-0.07, -0.00]
➖	idle	memory utilization	-0.12	[-0.16, -0.09]
➖	process_agent_real_time_mode	memory utilization	-0.16	[-0.20, -0.12]
➖	file_tree	memory utilization	-0.22	[-0.28, -0.16]
➖	file_to_blackhole	% cpu utilization	-0.26	[-6.82, +6.31]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.34	[-1.76, +1.08]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pducolin]

Including the testinfra changelog: https://github.com/DataDog/test-infra-definitions/compare/180d0c3c5d44...dba45dd5d1f1

I would like to automate this, in the meantime can you add the changelog on next bumps ? It helps investigations in case of issues

[usamasaqib]

Including the testinfra changelog: DataDog/[email protected]

I would like to automate this, in the meantime can you add the changelog on next bumps ? It helps investigations in case of issues

I can add for this one as well. Is there an example PR on how to do this properly?

[pducolin]

Looks like container tests are broken by this bump, let me check

[pducolin]

I can add for this one as well. Is there an example PR on how to do this properly?

What I usually do is I add manually the github compare, see https://github.com/DataDog/test-infra-definitions/compare/180d0c3c5d44...dba45dd5d1f1, where I use

https://github.com/DataDog/test-infra-definitions/compare/before_sha...after_sha

[usamasaqib]

ks like container tests are broken by this bump, let me check

Hey @pducolin any update on this?

[pducolin]

Hey @pducolin any update on this?

It was a dependency temporarily broken, I missed updating here, we communicated on slack. Can you bump again test-infra to trigger a new pipeline ?

[usamasaqib]

Closed because test-infra is being updated by https://github.com/DataDog/datadog-agent/pull/23336