datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Revert "Backport 23084 to 7.52.x"

Open yshapiro-57 opened this issue 1 year ago • 1 comments
trafficstars

Reverts DataDog/datadog-agent#23207 as the original PR is being temporarily reverted in https://github.com/DataDog/datadog-agent/pull/23219

yshapiro-57 avatar Feb 27 '24 22:02 yshapiro-57

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: a6379ade-0786-4c14-b7fc-048151b0685f Baseline: 6e268a33a252115c8fb5e0b6d93ff0e0188a45a8 Comparison: 0aa962b3e6c84d7ae88b1ac8212e401baf5f1981 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.52 [-6.06, +7.10]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +1.35 [+1.24, +1.46]
file_to_blackhole % cpu utilization +0.52 [-6.06, +7.10]
process_agent_real_time_mode memory utilization +0.31 [+0.25, +0.36]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.06 [-0.10, -0.03]
process_agent_standard_check_with_stats memory utilization -0.06 [-0.10, -0.03]
tcp_syslog_to_blackhole ingress throughput -0.15 [-0.21, -0.09]
process_agent_standard_check memory utilization -0.22 [-0.26, -0.17]
uds_dogstatsd_to_api_cpu % cpu utilization -0.36 [-1.79, +1.06]
idle memory utilization -1.07 [-1.12, -1.03]
otel_to_otel_logs ingress throughput -1.29 [-1.93, -0.65]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 27 '24 23:02 pr-commenter[bot]