datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[SBOM] Rebase on 'main' trivy branch

Open 0intro opened this issue 1 year ago • 2 comments

What does this PR do?

This change bumps Trivy version to upstream 2024-02-28.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

0intro avatar Feb 27 '24 18:02 0intro

Go Package Import Differences

This comment was omitted because it was over 65,536 characters. Please check the Gitlab Job logs to see its output.

cit-pr-commenter[bot] avatar Feb 27 '24 18:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: baa0a106-949d-4763-b04f-cced846cbb07 Baseline: 6964da53aae4a788c540294470fa574c6539710c Comparison: bfda5ec260fff351ce0c1f750e79c44b60f21362

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +9.61 [+9.53, +9.69]
process_agent_standard_check_with_stats memory utilization +8.96 [+8.93, +9.00]
idle memory utilization +8.24 [+8.21, +8.28]
process_agent_real_time_mode memory utilization +8.08 [+8.04, +8.12]
process_agent_standard_check memory utilization +8.04 [+8.00, +8.07]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -5.20 [-11.75, +1.36]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +9.61 [+9.53, +9.69]
process_agent_standard_check_with_stats memory utilization +8.96 [+8.93, +9.00]
idle memory utilization +8.24 [+8.21, +8.28]
process_agent_real_time_mode memory utilization +8.08 [+8.04, +8.12]
process_agent_standard_check memory utilization +8.04 [+8.00, +8.07]
trace_agent_msgpack ingress throughput +0.01 [-0.01, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.06, +0.01]
tcp_syslog_to_blackhole ingress throughput -0.32 [-0.37, -0.26]
uds_dogstatsd_to_api_cpu % cpu utilization -0.93 [-2.34, +0.49]
otel_to_otel_logs ingress throughput -1.05 [-1.69, -0.42]
file_to_blackhole % cpu utilization -5.20 [-11.75, +1.36]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 27 '24 19:02 pr-commenter[bot]

I had to increase dogstatsd's MAX_BINARY_SIZE from 38 MB to 39 MB. Otherwrise, I get this error:

DogStatsD static build size too big: 38979.265625 kB

0intro avatar Mar 01 '24 17:03 0intro

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Mar 04 '24 10:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #29383088

dd-devflow[bot] avatar Mar 04 '24 10:03 dd-devflow[bot]

/merge

0intro avatar Mar 05 '24 17:03 0intro

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 05 '24 17:03 dd-devflow[bot]

:x: MergeQueue

Build pipeline failed for a4f1c8a

You should have a look at the pipeline and see if the build failed because of your changes or not. When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 05 '24 17:03 dd-devflow[bot]

/merge

0intro avatar Mar 05 '24 18:03 0intro

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 05 '24 18:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 05 '24 20:03 dd-devflow[bot]