datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Backport PR with its labels

Open KevinFairise2 opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

Should also take PR labels when creating the backport

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

KevinFairise2 avatar Feb 27 '24 17:02 KevinFairise2

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 47d62712-286f-466a-91c3-d07d0916b8f7 Baseline: 57c16d2ff86cf11c0abfed5c4f929dd1cbc492b3 Comparison: a01e17e3c9ca58f1f3f2a74fc318a2bcc5b086bb Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.09 [-6.68, +6.50]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.21 [+0.58, +1.85]
uds_dogstatsd_to_api_cpu % cpu utilization +0.84 [-0.60, +2.27]
process_agent_standard_check memory utilization +0.24 [+0.20, +0.27]
idle memory utilization +0.19 [+0.16, +0.22]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.02]
process_agent_real_time_mode memory utilization +0.01 [-0.03, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.03 [-0.06, -0.01]
file_tree memory utilization -0.09 [-0.18, +0.00]
file_to_blackhole % cpu utilization -0.09 [-6.68, +6.50]
tcp_syslog_to_blackhole ingress throughput -0.18 [-0.24, -0.13]
process_agent_standard_check_with_stats memory utilization -0.34 [-0.37, -0.30]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 27 '24 18:02 pr-commenter[bot]

/merge

KevinFairise2 avatar Feb 28 '24 13:02 KevinFairise2

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 13:02 dd-devflow[bot]

The backport to backport-testing failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-backport-testing backport-testing
# Navigate to the new working tree
cd .worktrees/backport-backport-testing
# Create a new branch
git switch --create backport-23210-to-backport-testing
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03309d57ed08489b1235e84547c236cb502cc3b6
# Push it to GitHub
git push --set-upstream origin backport-23210-to-backport-testing
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-backport-testing

Then, create a pull request where the base branch is backport-testing and the compare/head branch is backport-23210-to-backport-testing.