datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[Backport 7.51.x] Bump embedded Python to address vulnerability

Open iliakur opened this issue 1 year ago • 1 comments

What does this PR do?

backport https://github.com/DataDog/datadog-agent/commit/ea28f91e9feadd333f07476448e399260dc423bf from https://github.com/DataDog/datadog-agent/pull/23110 to 7.51.x

iliakur avatar Feb 27 '24 12:02 iliakur

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 174f0939-625d-44d7-83b8-4a6907a4d08e Baseline: 0492ce1f19cdc5f53ee0f23a39082ce1f144c5cb Comparison: 5fc49aa16cb2875f965a2a3d2e4c736337425437 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.47 [-6.09, +7.02]
file_tree memory utilization -0.26 [-0.37, -0.14]
idle memory utilization -0.78 [-0.82, -0.74]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.92 [+1.12, +2.73]
process_agent_standard_check memory utilization +0.66 [+0.59, +0.72]
file_to_blackhole % cpu utilization +0.47 [-6.09, +7.02]
process_agent_standard_check_with_stats memory utilization +0.12 [+0.06, +0.18]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.07, +0.07]
trace_agent_json ingress throughput -0.02 [-0.05, +0.02]
tcp_syslog_to_blackhole ingress throughput -0.05 [-0.12, +0.02]
trace_agent_msgpack ingress throughput -0.07 [-0.09, -0.05]
file_tree memory utilization -0.26 [-0.37, -0.14]
process_agent_real_time_mode memory utilization -0.63 [-0.68, -0.59]
idle memory utilization -0.78 [-0.82, -0.74]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 27 '24 14:02 pr-commenter[bot]

/merge

iliakur avatar Feb 28 '24 13:02 iliakur

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 45m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 13:02 dd-devflow[bot]