datadog-agent
datadog-agent copied to clipboard
DataDog
Hasan.mahmood/aggregate usm stats state
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: ac2900d1-67a8-45b7-857a-bcd597560783 Baseline: 3365b2a179dcbcee7655eae2e550444d712b1593 Comparison: 49a1183679aeb0903d50826ebea7882b729552cb Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.04 | [-6.51, +6.59] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +0.23 | [+0.15, +0.32] |
| ➖ | file_to_blackhole | % cpu utilization | +0.04 | [-6.51, +6.59] |
| ➖ | process_agent_standard_check | memory utilization | +0.04 | [-0.00, +0.08] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.01, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.01 | [-0.04, +0.03] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.02 | [-0.05, +0.02] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.47 | [-0.50, -0.44] |
| ➖ | idle | memory utilization | -0.55 | [-0.59, -0.52] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.81 | [-0.87, -0.75] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.93 | [-2.33, +0.47] |
| ➖ | otel_to_otel_logs | ingress throughput | -1.09 | [-1.71, -0.47] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
![pr-commenter[bot] avatar](https://avatars.githubusercontent.com/u/365230?v=4 "Published by a pub.dev verified publisher"){kind=small}
Go Package Import Differences
Baseline: 6bf1f4d570fb75d0b1e54b5cb9cb033cf2743213 Comparison: a8f2e6ed0b6911b4cb763409e2a53277bf2f6bee
| binary | os | arch | change |
|---|---|---|---|
| agent | linux | amd64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| agent | linux | arm64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| agent | windows | amd64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| agent | darwin | amd64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| agent | darwin | arm64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| iot-agent | linux | amd64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| iot-agent | linux | arm64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| heroku-agent | linux | amd64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| cluster-agent | linux | amd64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| cluster-agent | linux | arm64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| process-agent | linux | amd64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| process-agent | linux | arm64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
| process-agent | windows | amd64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| process-agent | darwin | amd64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| process-agent | darwin | arm64 | +2, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
|
| heroku-process-agent | linux | amd64 | +3, -0
+github.com/DataDog/datadog-agent/cmd/system-probe/utils
+github.com/DataDog/datadog-agent/pkg/network/protocols/telemetry
+github.com/alecthomas/units
|
![cit-pr-commenter[bot] avatar](https://avatars.githubusercontent.com/in/330445?v=4 "Published by a pub.dev verified publisher"){kind=small}
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=37614144 --os-family=ubuntu
Note: This applies to commit a8f2e6ed
Regression Detector
Regression Detector Results
Run ID: c1f2832e-33b8-461c-af6d-975b335e9e8b Metrics dashboard Target profiles
Baseline: 6bf1f4d570fb75d0b1e54b5cb9cb033cf2743213 Comparison: a8f2e6ed0b6911b4cb763409e2a53277bf2f6bee
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +0.71 | [+0.62, +0.81] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.10 | [-0.71, +0.91] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.14 | [-1.04, +0.75] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.17 | [-2.92, +2.58] | Logs |
| ➖ | idle | memory utilization | -0.39 | [-0.44, -0.34] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -3.83 | [-8.62, +0.96] | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -6.32 | [-18.60, +5.96] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".