datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Remove agent-payload dependency from serverless agent

Open pgimalac opened this issue 1 year ago • 2 comments

What does this PR do?

Remove a few agent-payload packages from dependencies of serverless agent.

Motivation

Remove unused dependencies from serverless agent, in order to reduce init time duration and reduce binary size.

Additional Notes

There should be no functional change, only one type is moved in a separate package.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Feb 26 '24 10:02 pgimalac

Go Package Import Differences

Baseline: 3747ad67a4ee178c48809398057f64309387f8a6 Comparison: 61bee0e7615d302b0bd62fe1898a0cfb126bef86

binaryosarchchange
serverlesslinuxamd64
+0, -7
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
serverlesslinuxarm64
+0, -7
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
trace-agentlinuxamd64
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop
trace-agentlinuxarm64
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop
trace-agentwindowsamd64
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop
trace-agentwindows386
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop
trace-agentdarwinamd64
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop
trace-agentdarwinarm64
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop
heroku-trace-agentlinuxamd64
+0, -14
-github.com/DataDog/agent-payload/v5/contimage
-github.com/DataDog/agent-payload/v5/contlcycle
-github.com/DataDog/agent-payload/v5/cyclonedx_v1_4
-github.com/DataDog/agent-payload/v5/sbom
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/eventplatformimpl
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver
-github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl
-github.com/DataDog/datadog-agent/pkg/logs/auditor
-github.com/DataDog/datadog-agent/pkg/logs/client
-github.com/DataDog/datadog-agent/pkg/logs/client/http
-github.com/DataDog/datadog-agent/pkg/logs/diagnostic
-github.com/DataDog/datadog-agent/pkg/logs/metrics
-github.com/DataDog/datadog-agent/pkg/logs/sender
-github.com/DataDog/datadog-agent/pkg/util/startstop

cit-pr-commenter[bot] avatar Feb 26 '24 10:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 1a00b5b4-4527-4c32-bb86-04fa347e33b3 Baseline: 3747ad67a4ee178c48809398057f64309387f8a6 Comparison: 61bee0e7615d302b0bd62fe1898a0cfb126bef86 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.03 [-5.56, +7.62]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.24 [+0.82, +3.66]
file_to_blackhole % cpu utilization +1.03 [-5.56, +7.62]
otel_to_otel_logs ingress throughput +0.65 [+0.03, +1.28]
process_agent_standard_check_with_stats memory utilization +0.58 [+0.55, +0.61]
idle memory utilization +0.36 [+0.33, +0.39]
tcp_syslog_to_blackhole ingress throughput +0.33 [+0.27, +0.39]
process_agent_real_time_mode memory utilization +0.15 [+0.11, +0.19]
file_tree memory utilization +0.14 [+0.05, +0.22]
process_agent_standard_check memory utilization +0.02 [-0.02, +0.05]
trace_agent_msgpack ingress throughput +0.02 [+0.00, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.04, -0.00]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 27 '24 13:02 pr-commenter[bot]

/merge

pgimalac avatar Feb 28 '24 10:02 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 4 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 10:02 dd-devflow[bot]