usm: kafka: Removed kafka_last_tcp_seq_per_connection map

[guyarb]

What does this PR do?

Removes kafka_last_tcp_seq_per_connection map from the kafka filtering program

Motivation

We used the map to ensure we're not processing the same packet twice in the socket filter program. However, that is guaranteed already by protocol_dispatcher_entrypoint.

Additional Notes

The change simplifies the programs, removes a map, and spare 7.5MB from USM (assuming, 65K entries in the map).

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 5412a8ff-56c5-4808-a366-121aebd91908 Baseline: a396d12b70ad7337b30761efacde1d6101738959 Comparison: 06b0f781ed766f825678af5e37b5cd5041765b38 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.76	[-5.82, +7.35]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.76	[-5.82, +7.35]
➖	process_agent_standard_check	memory utilization	+0.41	[+0.38, +0.45]
➖	process_agent_standard_check_with_stats	memory utilization	+0.31	[+0.28, +0.34]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.26	[+0.21, +0.32]
➖	idle	memory utilization	+0.00	[-0.03, +0.04]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.01	[-0.04, +0.03]
➖	trace_agent_msgpack	ingress throughput	-0.02	[-0.02, -0.01]
➖	file_tree	memory utilization	-0.15	[-0.24, -0.06]
➖	process_agent_real_time_mode	memory utilization	-0.46	[-0.50, -0.42]
➖	otel_to_otel_logs	ingress throughput	-1.03	[-1.66, -0.41]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.26	[-2.67, +0.15]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[guyarb]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!