datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Add agent + APM installation powershell module

Open ISauve opened this issue 1 year ago • 1 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

ISauve avatar Feb 23 '24 20:02 ISauve

[Fast Unit Tests Report]

On pipeline 37440076 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37440076 --os-family=ubuntu

pr-commenter[bot] avatar Apr 22 '24 08:04 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 5149efdf-6f35-468f-813b-7f76cb1b6da4 Baseline: 65f9e9ffc6e9701920d14611f53155e4616d40b8 Comparison: 6c56b2ec55d0fffc3b0691bdf721cf48e671e61b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +6.38 [-15.70, +28.46]
pycheck_1000_100byte_tags % cpu utilization +2.21 [-2.44, +6.85]
basic_py_check % cpu utilization +0.43 [-2.36, +3.23]
uds_dogstatsd_to_api_cpu % cpu utilization +0.41 [-2.50, +3.32]
otel_to_otel_logs ingress throughput +0.04 [-0.34, +0.42]
uds_dogstatsd_to_api ingress throughput +0.02 [-0.19, +0.22]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.04, +0.04]
idle memory utilization -2.93 [-2.97, -2.90]
file_tree memory utilization -3.94 [-4.04, -3.85]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jun 05 '24 23:06 pr-commenter[bot]

/merge

derekwbrown avatar Jun 24 '24 20:06 derekwbrown

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jun 24 '24 20:06 dd-devflow[bot]