datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[NPM] Update DataDog/netlink to latest

Open hmahmood opened this issue 1 year ago • 16 comments

What does this PR do?

Includes fixes from https://github.com/vishvananda/netlink/pull/764

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

hmahmood avatar Feb 23 '24 20:02 hmahmood

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4dda3b8b-51a0-496f-b87f-65cd8e8d2683 Baseline: ce0e515eda490bd5ec728d7aa15cb098c1ff9f72 Comparison: 691280196eda5abcf1c6f7d80888e4e2c48f8b48

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.23 [-7.76, +5.29]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.76 [+0.31, +3.21]
otel_to_otel_logs ingress throughput +0.28 [-0.36, +0.92]
process_agent_standard_check memory utilization +0.23 [+0.19, +0.27]
tcp_syslog_to_blackhole ingress throughput +0.21 [+0.15, +0.27]
trace_agent_json ingress throughput +0.05 [+0.02, +0.08]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
process_agent_standard_check_with_stats memory utilization -0.04 [-0.07, -0.01]
process_agent_real_time_mode memory utilization -0.27 [-0.30, -0.23]
idle memory utilization -0.49 [-0.53, -0.46]
file_tree memory utilization -0.97 [-1.03, -0.91]
file_to_blackhole % cpu utilization -1.23 [-7.76, +5.29]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 23 '24 21:02 pr-commenter[bot]

/merge

hmahmood avatar Feb 26 '24 15:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 15:02 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Feb 26 '24 19:02 dd-devflow[bot]

/merge

hmahmood avatar Feb 26 '24 21:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 21:02 dd-devflow[bot]

/merge

hmahmood avatar Feb 26 '24 23:02 hmahmood

:x: MergeQueue

PR is already in db with waiting status

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 23:02 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Feb 27 '24 01:02 dd-devflow[bot]

/merge

hmahmood avatar Feb 28 '24 16:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 16:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 17:02 dd-devflow[bot]

:x: MergeQueue

Tests failed on this commit c07b263

You should fix those tests and then re-add your pull request to the queue!

Details

some checks are failing:

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 28 '24 19:02 dd-devflow[bot]

/merge

hmahmood avatar Feb 29 '24 18:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 18:02 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Feb 29 '24 22:02 dd-devflow[bot]

/merge

chouetz avatar Mar 01 '24 08:03 chouetz

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 08:03 dd-devflow[bot]

:x: MergeQueue

Build pipeline failed for 29f5867

You should have a look at the pipeline and see if the build failed because of your changes or not. When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 01 '24 09:03 dd-devflow[bot]

/merge

hmahmood avatar Mar 01 '24 15:03 hmahmood

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 4 builds ahead! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 15:03 dd-devflow[bot]

:x: MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 01 '24 15:03 dd-devflow[bot]

/merge

hmahmood avatar Mar 01 '24 15:03 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 15:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 3 builds ahead of this PR! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 17:03 dd-devflow[bot]