datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Bump embedded Python to address vulnerability

Open iliakur opened this issue 1 year ago • 1 comments

What does this PR do?

Bump embedded Python to 3.11.8

Motivation

Vulerability: CVE-2023-5678 on Windows because the embedded Python ships its own version of OpenSSL. For simplicity/consistency bump embedded Python for linux and macos too.

Jira cards: https://datadoghq.atlassian.net/browse/VULN-5166 https://datadoghq.atlassian.net/browse/AI-3778

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

iliakur avatar Feb 23 '24 16:02 iliakur

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 21c20190-41dc-43eb-a012-392df6310019 Baseline: 10051595024fc6899519547e4572873faf735419 Comparison: 54748a2fba22e24e9c76511bfc63e05b8c14bec2 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.66 [-7.20, +5.89]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.54 [-0.88, +1.95]
process_agent_standard_check_with_stats memory utilization +0.15 [+0.12, +0.19]
process_agent_standard_check memory utilization +0.15 [+0.11, +0.18]
trace_agent_msgpack ingress throughput +0.01 [+0.01, +0.02]
trace_agent_json ingress throughput +0.01 [-0.03, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.17 [-0.22, -0.12]
idle memory utilization -0.47 [-0.52, -0.42]
file_tree memory utilization -0.59 [-0.68, -0.50]
file_to_blackhole % cpu utilization -0.66 [-7.20, +5.89]
tcp_syslog_to_blackhole ingress throughput -0.81 [-0.87, -0.76]
otel_to_otel_logs ingress throughput -1.19 [-1.83, -0.56]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 26 '24 15:02 pr-commenter[bot]

/merge

iliakur avatar Feb 27 '24 09:02 iliakur

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 27 '24 09:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 27 '24 10:02 dd-devflow[bot]

The backport to 7.51.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.51.x 7.51.x
# Navigate to the new working tree
cd .worktrees/backport-7.51.x
# Create a new branch
git switch --create backport-23110-to-7.51.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea28f91e9feadd333f07476448e399260dc423bf
# Push it to GitHub
git push --set-upstream origin backport-23110-to-7.51.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.51.x

Then, create a pull request where the base branch is 7.51.x and the compare/head branch is backport-23110-to-7.51.x.