datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Remove opencensus from serverless agent

Open pgimalac opened this issue 1 year ago • 2 comments

THIS IS BLOCKED UNTIL THE otlp TAG IS REMOVED FROM THE SERVERLESS BUILD

What does this PR do?

Remove opencensus and various other dependencies from the serverless agent.

Motivation

Reduce as much as possible the size and init duration of the serverless agent

Additional Notes

Here is the import graph before this change, importing go.opentelemetry.io/collector/component/componenttest indirectly imports dozens of dependencies, that are really not used at all by the Serverless agent, since we are only using a single function from that package: graph

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Feb 23 '24 15:02 pgimalac

Go Package Import Differences

Baseline: c9f6fd00c09fb8d57a4e2fc8d4b7005e336b4f7a Comparison: 74b23b9b3779fd676952bc674423ada14f3c9f55

binaryosarchchange
agentwindowsamd64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
agentwindows386
+0, -1
-go.opentelemetry.io/collector/component/componenttest
serverlesslinuxamd64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
serverlesslinuxarm64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
trace-agentlinuxamd64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
trace-agentlinuxarm64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
trace-agentwindowsamd64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
trace-agentwindows386
+0, -1
-go.opentelemetry.io/collector/component/componenttest
trace-agentdarwinamd64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
trace-agentdarwinarm64
+0, -1
-go.opentelemetry.io/collector/component/componenttest
heroku-trace-agentlinuxamd64
+0, -1
-go.opentelemetry.io/collector/component/componenttest

cit-pr-commenter[bot] avatar Feb 23 '24 15:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: f9828e02-0e99-447c-aebc-c2a7cec6e906 Baseline: c9f6fd00c09fb8d57a4e2fc8d4b7005e336b4f7a Comparison: 74b23b9b3779fd676952bc674423ada14f3c9f55 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.14 [-6.46, +6.73]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +0.88 [+0.82, +0.94]
otel_to_otel_logs ingress throughput +0.78 [+0.17, +1.39]
file_tree memory utilization +0.45 [+0.35, +0.54]
process_agent_standard_check memory utilization +0.27 [+0.23, +0.30]
process_agent_standard_check_with_stats memory utilization +0.23 [+0.20, +0.26]
file_to_blackhole % cpu utilization +0.14 [-6.46, +6.73]
idle memory utilization +0.09 [+0.05, +0.13]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.01]
trace_agent_json ingress throughput -0.01 [-0.05, +0.02]
process_agent_real_time_mode memory utilization -0.25 [-0.28, -0.21]
uds_dogstatsd_to_api_cpu % cpu utilization -2.87 [-4.27, -1.46]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 23 '24 16:02 pr-commenter[bot]

Closing as it doesn't seem like we're going to remove the otlp tag from serverless in the end

pgimalac avatar May 14 '24 14:05 pgimalac