datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Use separately built Python dependencies when building the Agent

Open alopezz opened this issue 1 year ago • 4 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

alopezz avatar Feb 23 '24 09:02 alopezz

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 133b1c8f-c034-40ec-a3f5-8391483dafdb Baseline: 6e2b16ad2e0fc41fcd28af410a37ef73bbe7777c Comparison: 5d190c6b878317f145af342322e0275a862b4bc1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +3.71 [-3.17, +10.59]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +3.71 [-3.17, +10.59]
basic_py_check % cpu utilization +2.47 [+0.16, +4.78]
file_tree memory utilization +0.05 [-0.03, +0.12]
tcp_syslog_to_blackhole ingress throughput +0.02 [-0.03, +0.08]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.00 [-0.01, +0.01]
trace_agent_json ingress throughput -0.02 [-0.05, +0.01]
uds_dogstatsd_to_api_cpu % cpu utilization -0.15 [-1.60, +1.30]
otel_to_otel_logs ingress throughput -0.18 [-0.78, +0.43]
process_agent_standard_check_with_stats memory utilization -0.63 [-0.66, -0.60]
process_agent_real_time_mode memory utilization -0.65 [-0.70, -0.60]
idle memory utilization -0.72 [-0.75, -0.68]
process_agent_standard_check memory utilization -0.72 [-0.75, -0.68]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 28 '24 14:02 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30362534 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 16:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: d316e188-5051-4828-8a78-b1ab0d6f3c44 Baseline: 7c73709cd29ba76539b9885907c65a4bf0e6aab6 Comparison: 289da0db5583365d8f1ed5eea76b244c17a13e58

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +4.18 [-1.92, +10.28]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +4.18 [-1.92, +10.28]
basic_py_check % cpu utilization +1.75 [-0.67, +4.17]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.04]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.21, +0.20]
trace_agent_json ingress throughput -0.04 [-0.08, -0.01]
otel_to_otel_logs ingress throughput -0.17 [-0.64, +0.29]
process_agent_real_time_mode memory utilization -0.32 [-0.36, -0.28]
process_agent_standard_check memory utilization -0.41 [-0.46, -0.37]
idle memory utilization -0.45 [-0.48, -0.41]
file_tree memory utilization -0.57 [-0.66, -0.48]
tcp_syslog_to_blackhole ingress throughput -0.60 [-0.69, -0.51]
process_agent_standard_check_with_stats memory utilization -0.61 [-0.66, -0.57]
pycheck_1000_100byte_tags % cpu utilization -0.97 [-5.84, +3.91]
uds_dogstatsd_to_api_cpu % cpu utilization -1.00 [-3.92, +1.91]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 17:03 pr-commenter[bot]

[Fast Unit Tests Report]

On pipeline 31612466 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

/merge

alopezz avatar Apr 09 '24 14:04 alopezz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 09 '24 14:04 dd-devflow[bot]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 23m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 09 '24 14:04 dd-devflow[bot]

:x: MergeQueue

Build pipeline has failing jobs for 661469a

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures. When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #devflow with those details!

dd-devflow[bot] avatar Apr 09 '24 14:04 dd-devflow[bot]

/merge

alopezz avatar Apr 09 '24 15:04 alopezz

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 23m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Apr 09 '24 15:04 dd-devflow[bot]