datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

feat(ci): Review MQ jobs

Open chouetz opened this issue 1 year ago • 9 comments

What does this PR do?

Rework definition of jobs launched in MQ:

  • Prevent github jobs using path to run on mq.
  • Move windows jobs from github to gitlab.
  • Remove long tests and focus on linters.
  • Kept fast running tests (xxx_fast + windows secagent/sysprobe)

Motivation

Reduce time duration of MQ (from 45min to less than 20min)

Additional Notes

Test pipelines:

image image

Gitlab pipeline before: image

After: image

Possible Drawbacks / Trade-offs

The less jobs we run the more risk we have to detect logical conflicts on main. This selection is a trade-off

Describe how to test/QA your changes

chouetz avatar Feb 22 '24 17:02 chouetz

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: d02f380d-ac50-4b7e-af44-88feb6eb01c3 Baseline: 3bdc4d5f770a8c5cda447784815eb24107a3647d Comparison: 2078f0f27f7dfa1d63c4b9658bb40811284e08d8 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.11 [-6.70, +6.47]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +1.27 [+1.18, +1.37]
uds_dogstatsd_to_api_cpu % cpu utilization +0.39 [-1.03, +1.81]
process_agent_real_time_mode memory utilization +0.31 [+0.28, +0.34]
idle memory utilization +0.14 [+0.10, +0.18]
trace_agent_json ingress throughput +0.01 [-0.01, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
file_to_blackhole % cpu utilization -0.11 [-6.70, +6.47]
tcp_syslog_to_blackhole ingress throughput -0.19 [-0.25, -0.14]
otel_to_otel_logs ingress throughput -0.43 [-1.06, +0.20]
process_agent_standard_check_with_stats memory utilization -0.50 [-0.54, -0.47]
process_agent_standard_check memory utilization -0.63 [-0.66, -0.59]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 22 '24 18:02 pr-commenter[bot]

/merge

chouetz avatar Feb 28 '24 15:02 chouetz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 15:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 16:02 dd-devflow[bot]

:x: MergeQueue

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 28 '24 16:02 dd-devflow[bot]

/merge

chouetz avatar Feb 28 '24 18:02 chouetz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 18:02 dd-devflow[bot]

/merge -c

chouetz avatar Feb 28 '24 18:02 chouetz

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Feb 28 '24 18:02 dd-devflow[bot]

/merge

chouetz avatar Feb 29 '24 09:02 chouetz

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 09:02 dd-devflow[bot]

:x: MergeQueue

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 29 '24 09:02 dd-devflow[bot]

/merge

chouetz avatar Feb 29 '24 13:02 chouetz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 13:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 15:02 dd-devflow[bot]