datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Renaming oracle check

Open nenadnoveljic opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

nenadnoveljic avatar Feb 22 '24 14:02 nenadnoveljic

Go Package Import Differences

Baseline: e0749a853131cbe757fc611fcf96ac016f89dde5 Comparison: 176c5e8faef41752eff48ca5ec703544b591eea0

binaryosarchchange
agentlinuxamd64
+3, -2
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agentlinuxarm64
+3, -2
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agentwindowsamd64
+3, -2
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agentwindows386
+3, -2
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agentdarwinamd64
+3, -2
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
agentdarwinarm64
+3, -2
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle-dbm/config
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle

cit-pr-commenter[bot] avatar Feb 22 '24 14:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 9332456b-7d4d-4e4c-8f77-c5925f403be8 Baseline: e0749a853131cbe757fc611fcf96ac016f89dde5 Comparison: 176c5e8faef41752eff48ca5ec703544b591eea0 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -6.01 [-12.57, +0.55]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.11 [+0.49, +1.73]
file_tree memory utilization +0.49 [+0.40, +0.58]
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.35, +0.46]
process_agent_standard_check memory utilization +0.20 [+0.16, +0.24]
process_agent_standard_check_with_stats memory utilization +0.17 [+0.14, +0.21]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.03]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
uds_dogstatsd_to_api_cpu % cpu utilization -0.27 [-1.69, +1.16]
idle memory utilization -0.29 [-0.32, -0.26]
process_agent_real_time_mode memory utilization -0.50 [-0.53, -0.46]
file_to_blackhole % cpu utilization -6.01 [-12.57, +0.55]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 22 '24 16:02 pr-commenter[bot]