[CWS] optimization to regex evaluation part of string matches

[paulcacheux]

trafficstars

What does this PR do?

The main goal of this PR is to optimize patterns that look like

.*(word1|word2|...|wordN).*

to a for loop of strings.Contains.

Benchmark:

# Before:
BenchmarkRegexpEvaluator-10    	 1457696	       817.0 ns/op	       0 B/op	       0 allocs/op
# After:
BenchmarkRegexpEvaluator-10    	26507254	        44.97 ns/op	       0 B/op	       0 allocs/op

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 930d9b89-6520-4c24-8a39-ab43e889f575 Baseline: 2c5bc64e86f063b17d5fa5b45e85e90e27c29d61 Comparison: aca54ff58d6582cb85c15b6622594b24106eb732 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.50	[-7.06, +6.06]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	otel_to_otel_logs	ingress throughput	+1.61	[+0.97, +2.25]
➖	idle	memory utilization	+0.29	[+0.25, +0.34]
➖	process_agent_standard_check	memory utilization	+0.05	[+0.01, +0.10]
➖	trace_agent_msgpack	ingress throughput	+0.02	[+0.01, +0.02]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.05	[-0.09, -0.01]
➖	process_agent_standard_check_with_stats	memory utilization	-0.24	[-0.29, -0.19]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.25	[-0.31, -0.20]
➖	process_agent_real_time_mode	memory utilization	-0.45	[-0.49, -0.40]
➖	file_to_blackhole	% cpu utilization	-0.50	[-7.06, +6.06]
➖	file_tree	memory utilization	-0.52	[-0.62, -0.41]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.56	[-2.97, -0.15]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[paulcacheux]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[paulcacheux]

/merge -c

[dd-devflow[bot]]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[paulcacheux]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!