Fix config isknown to properly handle uppercase keys

[pgimalac]

What does this PR do?

Lowercase keys in config.IsKnown, so that it returns the correct information for uppercased keys.

Motivation

config.IsKnown currently returns false for all keys containing uppercased characters (eg. GUI_port). It relies on viper.GetKnownKeys, which returns lowercased keys.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Added an extensive unit test around IsKnown.

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: f467ae85-993a-41ec-84d0-cf931e79298a Baseline: ea98ae0218b75a6d3ea65a94991b608d44dfb7c5 Comparison: 6e13df7ecb43072afc4f210962d4b760e3cb416b Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.27	[-6.80, +6.26]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	otel_to_otel_logs	ingress throughput	+1.38	[+0.78, +1.99]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.75	[-0.70, +2.19]
➖	idle	memory utilization	+0.22	[+0.19, +0.26]
➖	file_tree	memory utilization	+0.11	[+0.03, +0.19]
➖	process_agent_standard_check_with_stats	memory utilization	+0.08	[+0.05, +0.11]
➖	trace_agent_json	ingress throughput	+0.04	[+0.01, +0.07]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_msgpack	ingress throughput	-0.02	[-0.03, -0.00]
➖	process_agent_standard_check	memory utilization	-0.16	[-0.20, -0.13]
➖	process_agent_real_time_mode	memory utilization	-0.26	[-0.30, -0.22]
➖	file_to_blackhole	% cpu utilization	-0.27	[-6.80, +6.26]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.61	[-0.67, -0.55]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pgimalac]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 5 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!