datadog-agent
datadog-agent copied to clipboard
[windows][cws] increase buffer size to ensure we receive notifications
What does this PR do?
Increases the size of the pre-allocated buffers used for transferring process notifications from the kernel to user space.
Motivation
It was discovered in testing that the previous size resulted in losing fidelity in process starts when the command line exceeded the expected size. The new size allocates enough to handle the OS mandated maximums.
Additional Notes
Possible Drawbacks / Trade-offs
This change will increase the memory consumption of system probe when CWS is enabled by ~10MB
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 1b2d9b72-582f-41fe-a24c-e27a5c770b03 Baseline: fadc999b4eee0eacba8e1b773e73133733e36fbc Comparison: 1897e9cf41c2fdeb5db59ae4a5a6384b511e4398 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -1.16 | [-7.68, +5.36] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +0.44 | [+0.35, +0.54] |
| ➖ | idle | memory utilization | +0.19 | [+0.16, +0.22] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.12 | [-0.52, +0.76] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.09 | [+0.06, +0.12] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.09 | [+0.05, +0.13] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.03, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.05 | [-0.07, -0.03] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.25 | [-0.31, -0.20] |
| ➖ | process_agent_standard_check | memory utilization | -0.81 | [-0.84, -0.77] |
| ➖ | file_to_blackhole | % cpu utilization | -1.16 | [-7.68, +5.36] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.71 | [-3.11, -0.31] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is going to start soon! (estimated merge in less than 49m)
Use /merge -c to cancel this operation!