Split remote-config client implementation from interface

[hush-hush]

What does this PR do?

This also split the types from the implementation allowing other component to provide task listeners without requiring the client implementation.

Describe how to test/QA your changes

Test that RC still works.

[cit-pr-commenter[bot]]

Go Package Import Differences

Baseline: 1bcb8b5016c93d703093ee2c4994aed9e867b3be Comparison: 04404d1a8cf00c8b0a4f1a830e5000ce6753d56b

binary	os	arch	change
agent	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
agent	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
agent	windows	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
agent	windows	386	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
agent	darwin	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
agent	darwin	arm64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
iot-agent	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
iot-agent	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
heroku-agent	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
cluster-agent	linux	amd64	+1, -1 -github.com/DataDog/datadog-agent/comp/remote-config/rcclient +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
cluster-agent	linux	arm64	+1, -1 -github.com/DataDog/datadog-agent/comp/remote-config/rcclient +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
process-agent	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
process-agent	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
process-agent	windows	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
process-agent	darwin	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
process-agent	darwin	arm64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
heroku-process-agent	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
system-probe	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
system-probe	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types
system-probe	windows	amd64	+2, -0 +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/rcclientimpl +github.com/DataDog/datadog-agent/comp/remote-config/rcclient/types

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 268eaa93-8234-4ee3-9bd5-93b8d40eb448 Baseline: 1bcb8b5016c93d703093ee2c4994aed9e867b3be Comparison: 04404d1a8cf00c8b0a4f1a830e5000ce6753d56b

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.39	[-6.93, +6.15]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	tcp_syslog_to_blackhole	ingress throughput	+1.23	[+1.17, +1.29]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.97	[-0.49, +2.43]
➖	process_agent_real_time_mode	memory utilization	+0.10	[+0.06, +0.15]
➖	trace_agent_json	ingress throughput	+0.02	[-0.00, +0.04]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.01, +0.00]
➖	idle	memory utilization	-0.32	[-0.36, -0.28]
➖	file_to_blackhole	% cpu utilization	-0.39	[-6.93, +6.15]
➖	process_agent_standard_check_with_stats	memory utilization	-0.40	[-0.45, -0.35]
➖	process_agent_standard_check	memory utilization	-0.61	[-0.66, -0.57]
➖	otel_to_otel_logs	ingress throughput	-1.46	[-2.09, -0.83]
➖	file_tree	memory utilization	-1.73	[-1.84, -1.61]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[hush-hush]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!