datadog-agent
datadog-agent copied to clipboard
[CWS] add rule_id pprof labels on evaluation function
What does this PR do?
This PR adds a new pprof label around rule evaluation allowing to measure and compare the CPU impact of each rule
The implementation is a bit ugly, but required to not use more CPU allocating labels and labelset and labelmaps and context value than actually evaluating the rule..
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: d36ec586-feaf-4b1a-adde-eb49745ea7e1 Baseline: 7b4702d897b65d2c0333c3e650574277fc629dd7 Comparison: fe2efd7077b671a6a92b3762be83ff21db976953 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -3.09 | [-9.71, +3.52] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | idle | memory utilization | +0.99 | [+0.96, +1.02] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.54 | [+0.51, +0.58] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.24 | [+0.18, +0.30] |
| ➖ | file_tree | memory utilization | +0.23 | [+0.16, +0.30] |
| ➖ | process_agent_standard_check | memory utilization | +0.21 | [+0.17, +0.25] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.00, +0.01] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.02, -0.01] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.16 | [-0.19, -0.13] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.30 | [-1.73, +1.14] |
| ➖ | otel_to_otel_logs | ingress throughput | -1.28 | [-1.88, -0.67] |
| ➖ | file_to_blackhole | % cpu utilization | -3.09 | [-9.71, +3.52] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Go Package Import Differences
Baseline: 7b4702d897b65d2c0333c3e650574277fc629dd7 Comparison: fe2efd7077b671a6a92b3762be83ff21db976953
| binary | os | arch | change |
|---|---|---|---|
| agent | windows | amd64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| cluster-agent | linux | amd64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| cluster-agent | linux | arm64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| security-agent | linux | amd64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| security-agent | linux | arm64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| system-probe | linux | amd64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| system-probe | linux | arm64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
| system-probe | windows | amd64 | +1, -0
+github.com/DataDog/datadog-agent/pkg/security/secl/utils
|
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is next! (estimated merge in less than 50m)
Use /merge -c to cancel this operation!