datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[NPM-3219] Try to ensure UDP and TCP don't have the same port

Open hmahmood opened this issue 1 year ago • 1 comments

What does this PR do?

Fix failures like: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/437854305#L1214. This failure can only happen if both TCP and UDP get the same port, which should be very rare, but possible. The changes here try to get a unique port for all four protocols, tcp, udp, tcp6, and udp6.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

hmahmood avatar Feb 20 '24 22:02 hmahmood

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 6147fe29-3d46-4eae-8956-a3069e4d76f2 Baseline: ef69e4a70406f169b9abb174c4e4cd403ac7705e Comparison: 9b6d73edcd0612e7dad827f8f8d7bdc370b06286 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.17 [-6.35, +6.70]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.18 [+0.76, +3.60]
process_agent_real_time_mode memory utilization +0.40 [+0.37, +0.43]
idle memory utilization +0.31 [+0.28, +0.34]
file_to_blackhole % cpu utilization +0.17 [-6.35, +6.70]
tcp_syslog_to_blackhole ingress throughput +0.13 [+0.07, +0.19]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
file_tree memory utilization -0.00 [-0.09, +0.09]
trace_agent_json ingress throughput -0.03 [-0.05, +0.00]
process_agent_standard_check_with_stats memory utilization -0.04 [-0.07, -0.02]
process_agent_standard_check memory utilization -0.16 [-0.20, -0.13]
otel_to_otel_logs ingress throughput -0.47 [-1.08, +0.13]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 21 '24 00:02 pr-commenter[bot]

/merge

hmahmood avatar Feb 26 '24 15:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 15:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 13 builds ahead of this PR! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 16:02 dd-devflow[bot]

:x: MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 21:02 dd-devflow[bot]

/merge

hmahmood avatar Feb 26 '24 21:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 21:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 22:02 dd-devflow[bot]