datadog-agent
datadog-agent copied to clipboard
Make containers e2e test not complain on unexpected tags on nginx
What does this PR do?
Make the containers
new-e2e tests ignore unexpected tags on nginx
and redis
metrics.
Motivation
If @DataDog/agent-integrations team modify the nginx
or redis
checks and make them send legit new tags, we don’t want to impact the containers
e2e tests.
Additional Notes
Possible Drawbacks / Trade-offs
This effectively reduces the test coverage but nginx
and redis
tags should be asserted elsewhere.
Describe how to test/QA your changes
Check the new-e2e-containers
GitLab job in the CI pipeline.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 3551d154-8824-4fcb-b7fa-ae79ca329fcf Baseline: 8a928218504a6a8b89f05c17ba5093ba78056676 Comparison: fcc17e418d76546fd4e7644f85141b6edac7332e Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -1.32 | [-7.86, +5.21] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.79 | [-0.64, +2.22] |
➖ | process_agent_real_time_mode | memory utilization | +0.64 | [+0.61, +0.68] |
➖ | file_tree | memory utilization | +0.17 | [+0.10, +0.25] |
➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.00, +0.02] |
➖ | process_agent_standard_check | memory utilization | +0.01 | [-0.03, +0.05] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | trace_agent_json | ingress throughput | -0.01 | [-0.02, +0.00] |
➖ | otel_to_otel_logs | ingress throughput | -0.11 | [-0.70, +0.49] |
➖ | idle | memory utilization | -0.18 | [-0.21, -0.15] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.19 | [-0.22, -0.16] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.61 | [-0.68, -0.54] |
➖ | file_to_blackhole | % cpu utilization | -1.32 | [-7.86, +5.21] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 2 builds ahead! (estimated merge in less than 27m)
Use /merge -c
to cancel this operation!
:x: MergeQueue
Build pipeline failed for a541f86
You should have a look at the pipeline and see if the build failed because of your changes or not. When you are ready, re-add your pull request to the queue!
⚠️ Do NOT retry failed jobs directly.
They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.
Details
List of failed jobs:
- lint_linux-arm64
- lint_flavor_heroku_linux-x64
- lint_flavor_dogstatsd_linux-x64
- lint_flavor_iot_linux-x64
- lint_linux-x64
Go to failed Gitlab pipeline.
If you need support, contact us on Slack #ci-interfaces with those details!
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove
command.
Use /merge -c
to cancel this operation!
:steam_locomotive: MergeQueue
Added to the queue.
This build is next! (estimated merge in less than 26m)
Use /merge -c
to cancel this operation!