datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1219] Create a trace log component

Open pgimalac opened this issue 1 year ago • 3 comments

What does this PR do?

Move the trace logger component from comp/core/log to its own package in comp/core/log/tracelogimpl.

Motivation

Decouple trace-agent from core-agent. The end goal would be able to be able to build the serverless agent without the trace agent.

It also removes a lot of dependencies from some modules (which don't otherwise depend on pkg/trace), and in turn from some agents (see https://github.com/DataDog/datadog-agent/pull/23004#issuecomment-1954501638): 35~38 packages removed from cluster-agent, dogstatsd, process-agent, heroku agent, security-agent, and system-probe.

Additional Notes

There shouldn't be any functional change.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Check that the trace-agent can still start and log properly.

pgimalac avatar Feb 20 '24 15:02 pgimalac

Go Package Import Differences

Baseline: 7e1916dea3dd943900ebe80b1d2c60b65f4943aa Comparison: 96d6103f4d78013d1ef8a7cbc69412c5377928ec

binaryosarchchange
agentlinuxamd64
+0, -3
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
agentlinuxarm64
+0, -3
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
agentwindowsamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
agentwindows386
+0, -1
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
agentdarwinamd64
+0, -3
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
agentdarwinarm64
+0, -3
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
iot-agentlinuxamd64
+0, -8
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
iot-agentlinuxarm64
+0, -8
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
heroku-agentlinuxamd64
+0, -3
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
cluster-agentlinuxamd64
+0, -37
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
cluster-agentlinuxarm64
+0, -37
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
cluster-agent-cloudfoundrylinuxamd64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
cluster-agent-cloudfoundrylinuxarm64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
dogstatsdlinuxamd64
+0, -37
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
dogstatsdlinuxarm64
+0, -37
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
process-agentlinuxamd64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
process-agentlinuxarm64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
process-agentwindowsamd64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
process-agentdarwinamd64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
process-agentdarwinarm64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
heroku-process-agentlinuxamd64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
security-agentlinuxamd64
+0, -37
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
security-agentlinuxarm64
+0, -37
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
system-probelinuxamd64
+0, -35
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
system-probelinuxarm64
+0, -35
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
system-probewindowsamd64
+0, -38
-github.com/DataDog/datadog-agent/pkg/obfuscate
-github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace
-github.com/DataDog/datadog-agent/pkg/trace/config
-github.com/DataDog/datadog-agent/pkg/trace/log
-github.com/DataDog/datadog-agent/pkg/trace/telemetry
-github.com/DataDog/datadog-agent/pkg/trace/traceutil
-github.com/DataDog/go-sqllexer
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/azure
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/ec2
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/gcp
-github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source
-github.com/hashicorp/go-version
-github.com/knadh/koanf/maps
-github.com/knadh/koanf/providers/confmap
-github.com/knadh/koanf/v2
-github.com/mitchellh/copystructure
-github.com/mitchellh/reflectwalk
-github.com/outcaste-io/ristretto
-github.com/outcaste-io/ristretto/z
-github.com/outcaste-io/ristretto/z/simd
-go.opentelemetry.io/collector/component
-go.opentelemetry.io/collector/config/configtelemetry
-go.opentelemetry.io/collector/confmap
-go.opentelemetry.io/collector/confmap/internal/mapstructure
-go.opentelemetry.io/collector/featuregate
-go.opentelemetry.io/collector/pdata/internal
-go.opentelemetry.io/collector/pdata/internal/data
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1
-go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1
-go.opentelemetry.io/collector/pdata/pcommon
-go.opentelemetry.io/collector/semconv/v1.6.1
trace-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl
trace-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl
trace-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl
trace-agentwindows386
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl
trace-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl
trace-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl
heroku-trace-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/comp/core/log/tracelogimpl

cit-pr-commenter[bot] avatar Feb 20 '24 15:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: c6d2e100-6bbe-4b81-877d-f0fff8f01d36 Baseline: 7e1916dea3dd943900ebe80b1d2c60b65f4943aa Comparison: 96d6103f4d78013d1ef8a7cbc69412c5377928ec

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.04 [-6.51, +6.60]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_standard_check memory utilization +1.09 [+1.04, +1.14]
process_agent_standard_check_with_stats memory utilization +0.90 [+0.86, +0.94]
file_tree memory utilization +0.76 [+0.70, +0.83]
process_agent_real_time_mode memory utilization +0.28 [+0.23, +0.33]
idle memory utilization +0.07 [+0.02, +0.12]
file_to_blackhole % cpu utilization +0.04 [-6.51, +6.60]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
tcp_syslog_to_blackhole ingress throughput -0.24 [-0.30, -0.19]
otel_to_otel_logs ingress throughput -0.80 [-1.43, -0.17]
uds_dogstatsd_to_api_cpu % cpu utilization -1.38 [-2.80, +0.05]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 20 '24 16:02 pr-commenter[bot]

@knusbaum I actually initially moved it to comp/trace but @ogaca-dd argued it was better to keep it in comp/core/log along with the actual definition of the Component Ie. keep implementations together Let me know if I should move it back 😄

pgimalac avatar Mar 05 '24 16:03 pgimalac

/merge

pgimalac avatar Mar 06 '24 16:03 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 4 builds ahead! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 06 '24 16:03 dd-devflow[bot]