datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

New alerting for consecutive failures

Open chouetz opened this issue 1 year ago • 3 comments

What does this PR do?

Add a new invoke task for tracking of consecutive failures

Motivation

Alerting currently work on fixed duration, so we can count a number of failures, but not a number of consecutive failures, which is more relevant in our context has we have many flakes in job execution (both because of test themselves and infrastructure) This implementation saves a status of each pipeline and compare with the stored information to create a cumulative count.

Additional Notes

We might want to upload this statistic in datadog in a second phase to have a monitor on it, rather than an ad-hoc slack notification.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Added some UT Trigger full pipelines as they activate the notification job

chouetz avatar Feb 20 '24 13:02 chouetz

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

chouetz avatar Feb 20 '24 13:02 chouetz

:steam_locomotive: Gitlab pipeline started

Started pipeline #28547317

dd-devflow[bot] avatar Feb 20 '24 13:02 dd-devflow[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 15aa099e-5b40-4a43-9073-8ae22df81d7a Baseline: 164655360b216947085c7319286f7c72327626e8 Comparison: bb5f1bb025401e2caea6b4f8c4aa97251a749121 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.50 [-5.13, +8.13]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.50 [-5.13, +8.13]
file_tree memory utilization +0.84 [+0.74, +0.93]
process_agent_standard_check memory utilization +0.65 [+0.62, +0.69]
tcp_syslog_to_blackhole ingress throughput +0.30 [+0.24, +0.36]
process_agent_standard_check_with_stats memory utilization +0.27 [+0.24, +0.30]
trace_agent_msgpack ingress throughput +0.01 [-0.01, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.04 [-0.08, -0.01]
idle memory utilization -0.15 [-0.19, -0.10]
process_agent_real_time_mode memory utilization -0.15 [-0.19, -0.11]
uds_dogstatsd_to_api_cpu % cpu utilization -0.38 [-1.79, +1.04]
otel_to_otel_logs ingress throughput -0.75 [-1.39, -0.12]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 20 '24 14:02 pr-commenter[bot]

/merge

chouetz avatar Feb 28 '24 10:02 chouetz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 10:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 4 builds ahead of this PR! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 11:02 dd-devflow[bot]