datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Creating an authtoken comp

Open hush-hush opened this issue 1 year ago • 2 comments

What does this PR do?

The new component ensure the creation of the auth_token. This is now required by other component than the api. Without this, the inventoryagent comp would tries to contact other process before the auth_token was created.

Describe how to test/QA your changes

  1. Make sure the auth_token is not already present
  2. Run the Agent and check that you don't have log like:
2024-02-16 22:35:09 EST | CORE | INFO | (comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go:192 in getCorrectConfig) | could not fetch security-agent process configuration: unable to read authentication token file: open C:\ProgramData\Datadog\auth_token: The system cannot find the file specified.
2024-02-16 22:35:09 EST | CORE | INFO | (comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go:192 in getCorrectConfig) | could not fetch process-agent process configuration: unable to read authentication token file: open C:\ProgramData\Datadog\auth_token: The system cannot find the file specified.
2024-02-16 22:35:09 EST | CORE | INFO | (comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go:192 in getCorrectConfig) | could not fetch trace-agent process configuration: unable to read authentication token file: open C:\ProgramData\Datadog\auth_token: The system cannot find the file specified.

hush-hush avatar Feb 19 '24 16:02 hush-hush

Go Package Import Differences

Baseline: 5d2a79a61d2da5a71197cdf9e696b9b42117e874 Comparison: 93143edef1333f680db1ca3871560d8a7ceb1b23

binaryosarchchange
agentlinuxamd64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
agentlinuxarm64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
agentwindowsamd64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
agentwindows386
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
agentdarwinamd64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
agentdarwinarm64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
iot-agentlinuxamd64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
iot-agentlinuxarm64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
heroku-agentlinuxamd64
+3, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
cluster-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
cluster-agentlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/createandfetchimpl
dogstatsdlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl
dogstatsdlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/api/authtoken
+github.com/DataDog/datadog-agent/comp/api/authtoken/fetchonlyimpl

cit-pr-commenter[bot] avatar Feb 19 '24 16:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4aa9b304-0250-4d98-a5a0-4bf3e6402108 Baseline: 5d2a79a61d2da5a71197cdf9e696b9b42117e874 Comparison: 93143edef1333f680db1ca3871560d8a7ceb1b23 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.52 [-7.10, +6.05]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.48 [+1.04, +3.93]
otel_to_otel_logs ingress throughput +0.41 [-0.19, +1.00]
process_agent_standard_check_with_stats memory utilization +0.36 [+0.32, +0.39]
process_agent_standard_check memory utilization +0.16 [+0.12, +0.20]
idle memory utilization +0.07 [+0.04, +0.10]
trace_agent_json ingress throughput +0.05 [+0.00, +0.09]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.02]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
file_tree memory utilization -0.03 [-0.12, +0.06]
process_agent_real_time_mode memory utilization -0.05 [-0.08, -0.02]
tcp_syslog_to_blackhole ingress throughput -0.16 [-0.21, -0.10]
file_to_blackhole % cpu utilization -0.52 [-7.10, +6.05]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 19 '24 17:02 pr-commenter[bot]

/merge

hush-hush avatar Feb 21 '24 16:02 hush-hush

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 21 '24 16:02 dd-devflow[bot]