datadog-agent
datadog-agent copied to clipboard
system-probe: allow building and loading config on darwin
What does this PR do?
This PR allows building the system probe on macOS (it can't do much yet but it builds):
inv -e system-probe.build --no-bundle
and removes most restrictions to linux by moving what can be to unix tags (unix is basically equals to linux + darwin), and allows the config to be loaded on darwin.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: ce63a953-7f97-4702-8c1a-2f1a16f09829 Baseline: a82a8f97aa98a0654fa09dfd295c5f01a3162423 Comparison: ba9be00cf54cb7fc4a5c848150a86f044693e4c1 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.05 | [-6.54, +6.63] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.64 | [-0.78, +2.05] |
| ➖ | file_tree | memory utilization | +0.57 | [+0.49, +0.65] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.39 | [+0.36, +0.42] |
| ➖ | idle | memory utilization | +0.19 | [+0.15, +0.23] |
| ➖ | file_to_blackhole | % cpu utilization | +0.05 | [-6.54, +6.63] |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.02] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.15 | [-0.21, -0.10] |
| ➖ | process_agent_standard_check | memory utilization | -0.23 | [-0.26, -0.19] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.30 | [-0.34, -0.27] |
| ➖ | otel_to_otel_logs | ingress throughput | -1.03 | [-1.65, -0.42] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 2 builds ahead! (estimated merge in less than 50m)
Use /merge -c to cancel this operation!