datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[windows][cws] add specific registry types for notifications

Open derekwbrown opened this issue 1 year ago • 1 comments

Updates previous PR. In previous PR, each file type was given a specific go type, but didn't follow through on registry types. This completes that operation by providing distinct types for each registry notification.

derekwbrown avatar Feb 16 '24 23:02 derekwbrown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e9e1d586-be97-4b34-ab69-f6f491ce9d2b Baseline: 519b74dcd38c0fd2314d92a717a80aaa4a6bac5d Comparison: 448de74073bb005db72b0bb03e2f5d243efcbafe

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.44 [-6.12, +7.00]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.44 [-6.12, +7.00]
idle memory utilization +0.31 [+0.28, +0.34]
otel_to_otel_logs ingress throughput +0.28 [-0.36, +0.92]
process_agent_real_time_mode memory utilization +0.27 [+0.23, +0.30]
trace_agent_json ingress throughput +0.03 [+0.01, +0.06]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.00 [-0.01, +0.01]
process_agent_standard_check_with_stats memory utilization -0.12 [-0.15, -0.09]
tcp_syslog_to_blackhole ingress throughput -0.40 [-0.46, -0.34]
file_tree memory utilization -0.50 [-0.56, -0.44]
process_agent_standard_check memory utilization -0.72 [-0.75, -0.68]
uds_dogstatsd_to_api_cpu % cpu utilization -4.27 [-5.64, -2.90]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 17 '24 00:02 pr-commenter[bot]

/merge

derekwbrown avatar Feb 29 '24 03:02 derekwbrown

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 03:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 03:02 dd-devflow[bot]