datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Fix udp_sendpage handling on some kernels

Open hmahmood opened this issue 1 year ago • 1 comments

What does this PR do?

Fixes double-counting udp ipv4 sends on some kernels. This happens because this particular kernel (6.1.76) kernel includes this commit: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/net/ipv4/udp.c?h=v6.1.77&id=ac8c69e448f7e43586e102395844a117b0595031. This change means that udp_sendpage would also end up calling ip_make_skb, and since we hook both, we end up double counting ipv4 UDP sends.

This seems to be a short-lived change since it is absent in kernels 6.2 and above, so test runs on these kernels pass in the CI.

Motivation

Fix test failures like: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/434932101#L417

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

hmahmood avatar Feb 16 '24 21:02 hmahmood

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 2f4c68d9-4edf-4add-a517-3d8e450760a1 Baseline: 10051595024fc6899519547e4572873faf735419 Comparison: ea3f96e772206fddf83609f7aa52011cdf6699ee Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.43 [-8.00, +5.15]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.76 [+0.73, +0.80]
file_tree memory utilization +0.69 [+0.59, +0.78]
process_agent_standard_check memory utilization +0.47 [+0.42, +0.51]
otel_to_otel_logs ingress throughput +0.24 [-0.39, +0.86]
trace_agent_msgpack ingress throughput +0.03 [+0.02, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.03]
process_agent_standard_check_with_stats memory utilization -0.07 [-0.12, -0.03]
tcp_syslog_to_blackhole ingress throughput -0.17 [-0.24, -0.11]
process_agent_real_time_mode memory utilization -0.33 [-0.38, -0.29]
uds_dogstatsd_to_api_cpu % cpu utilization -0.68 [-2.11, +0.74]
file_to_blackhole % cpu utilization -1.43 [-8.00, +5.15]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 16 '24 23:02 pr-commenter[bot]

/merge

hmahmood avatar Feb 23 '24 15:02 hmahmood

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 23 '24 15:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 23 '24 16:02 dd-devflow[bot]